From: Tom Tromey <tromey@redhat.com>
To: Siddhesh Poyarekar <siddhesh@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][v2] Make SIZE element for dwarf_block as size_t
Date: Wed, 25 Jul 2012 17:58:00 -0000 [thread overview]
Message-ID: <87r4rzhgdv.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20120725225053.3119effa@spoyarek> (Siddhesh Poyarekar's message of "Wed, 25 Jul 2012 22:50:53 +0530")
>>>>> "Siddhesh" == Siddhesh Poyarekar <siddhesh@redhat.com> writes:
Siddhesh> I haven't been able to figure out a test case to reproduce this
Siddhesh> problem, so I have stuck to ensuring that it does not cause a
Siddhesh> regression in the testsuite.
I think that is good enough.
Siddhesh> 2012-07-25 Siddhesh Poyarekar <siddhesh@redhat.com>
Siddhesh> * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Expand parameter
Siddhesh> SIZE to size_t.
Siddhesh> (dwarf2_evaluate_loc_desc): Likewise.
Siddhesh> (dwarf2_loc_desc_needs_frame): Likewise.
Siddhesh> (locexpr_describe_location_1): Likewise.
Siddhesh> * dwarf2loc.h (struct dwarf2_locexpr_baton): Make SIZE as
Siddhesh> size_t.
Siddhesh> (struct dwarf2_loclist_baton): Likewise.
Siddhesh> * dwarf2read.c (struct dwarf_block): Likewise.
Siddhesh> (dump_die_shallow): Use pulongest to print dwarf_block.size.
Siddhesh> (decode_locdesc): Expand SIZE and I to size_t.
Ok.
Tom
prev parent reply other threads:[~2012-07-25 17:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-22 7:47 [PATCH] " Siddhesh Poyarekar
2012-07-22 8:28 ` Siddhesh Poyarekar
2012-07-23 14:41 ` Tom Tromey
2012-07-23 17:29 ` Siddhesh Poyarekar
2012-07-23 18:53 ` Tom Tromey
2012-07-25 17:21 ` [PATCH][v2] " Siddhesh Poyarekar
2012-07-25 17:58 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4rzhgdv.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=siddhesh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox