From: Tom Tromey <tromey@redhat.com>
To: Siddhesh Poyarekar <siddhesh@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Make SIZE element for dwarf_block as size_t
Date: Mon, 23 Jul 2012 14:41:00 -0000 [thread overview]
Message-ID: <87fw8isfoo.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20120722135746.1e864ddc@spoyarek> (Siddhesh Poyarekar's message of "Sun, 22 Jul 2012 13:57:46 +0530")
>>>>> "Siddhesh" == Siddhesh Poyarekar <siddhesh@redhat.com> writes:
Siddhesh> A small adjustment to this patch to adjust for the expansion of
Siddhesh> dwarf_block.size -- a couple of local variables in decode_locdesc
Siddhesh> needed expansion as well.
What about dwarf2_evaluate_loc_desc_full?
It has 'unsigned short size' as an argument but is called from
indirect_pieced_value:
struct dwarf2_locexpr_baton baton;
[...]
return dwarf2_evaluate_loc_desc_full (TYPE_TARGET_TYPE (type), frame,
baton.data, baton.size, baton.per_cu,
piece->v.ptr.offset + byte_offset);
It would have been useful to me if you had written a bit about how you
wrote this patch and verified it. As it is, with no information on
that, I went grepping through the source to see if the patch was
complete.
Tom
next prev parent reply other threads:[~2012-07-23 14:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-22 7:47 Siddhesh Poyarekar
2012-07-22 8:28 ` Siddhesh Poyarekar
2012-07-23 14:41 ` Tom Tromey [this message]
2012-07-23 17:29 ` Siddhesh Poyarekar
2012-07-23 18:53 ` Tom Tromey
2012-07-25 17:21 ` [PATCH][v2] " Siddhesh Poyarekar
2012-07-25 17:58 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fw8isfoo.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=siddhesh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox