From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17833 invoked by alias); 23 Jul 2012 14:41:46 -0000 Received: (qmail 17816 invoked by uid 22791); 23 Jul 2012 14:41:45 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 Jul 2012 14:41:28 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6NEfS76027317 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 23 Jul 2012 10:41:28 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q6NEfRuo009006 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 23 Jul 2012 10:41:27 -0400 From: Tom Tromey To: Siddhesh Poyarekar Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Make SIZE element for dwarf_block as size_t References: <20120722131658.2809309e@spoyarek> <20120722135746.1e864ddc@spoyarek> Date: Mon, 23 Jul 2012 14:41:00 -0000 In-Reply-To: <20120722135746.1e864ddc@spoyarek> (Siddhesh Poyarekar's message of "Sun, 22 Jul 2012 13:57:46 +0530") Message-ID: <87fw8isfoo.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00445.txt.bz2 >>>>> "Siddhesh" == Siddhesh Poyarekar writes: Siddhesh> A small adjustment to this patch to adjust for the expansion of Siddhesh> dwarf_block.size -- a couple of local variables in decode_locdesc Siddhesh> needed expansion as well. What about dwarf2_evaluate_loc_desc_full? It has 'unsigned short size' as an argument but is called from indirect_pieced_value: struct dwarf2_locexpr_baton baton; [...] return dwarf2_evaluate_loc_desc_full (TYPE_TARGET_TYPE (type), frame, baton.data, baton.size, baton.per_cu, piece->v.ptr.offset + byte_offset); It would have been useful to me if you had written a bit about how you wrote this patch and verified it. As it is, with no information on that, I went grepping through the source to see if the patch was complete. Tom