From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8150 invoked by alias); 25 Jul 2012 17:58:52 -0000 Received: (qmail 8133 invoked by uid 22791); 25 Jul 2012 17:58:51 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 Jul 2012 17:58:38 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6PHwcR3001310 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 25 Jul 2012 13:58:38 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6PHwbeK010894 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 25 Jul 2012 13:58:37 -0400 From: Tom Tromey To: Siddhesh Poyarekar Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][v2] Make SIZE element for dwarf_block as size_t References: <20120722131658.2809309e@spoyarek> <20120722135746.1e864ddc@spoyarek> <87fw8isfoo.fsf@fleche.redhat.com> <20120723225922.30d293e7@spoyarek> <87boj6qphd.fsf@fleche.redhat.com> <20120725225053.3119effa@spoyarek> Date: Wed, 25 Jul 2012 17:58:00 -0000 In-Reply-To: <20120725225053.3119effa@spoyarek> (Siddhesh Poyarekar's message of "Wed, 25 Jul 2012 22:50:53 +0530") Message-ID: <87r4rzhgdv.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00565.txt.bz2 >>>>> "Siddhesh" == Siddhesh Poyarekar writes: Siddhesh> I haven't been able to figure out a test case to reproduce this Siddhesh> problem, so I have stuck to ensuring that it does not cause a Siddhesh> regression in the testsuite. I think that is good enough. Siddhesh> 2012-07-25 Siddhesh Poyarekar Siddhesh> * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Expand parameter Siddhesh> SIZE to size_t. Siddhesh> (dwarf2_evaluate_loc_desc): Likewise. Siddhesh> (dwarf2_loc_desc_needs_frame): Likewise. Siddhesh> (locexpr_describe_location_1): Likewise. Siddhesh> * dwarf2loc.h (struct dwarf2_locexpr_baton): Make SIZE as Siddhesh> size_t. Siddhesh> (struct dwarf2_loclist_baton): Likewise. Siddhesh> * dwarf2read.c (struct dwarf_block): Likewise. Siddhesh> (dump_die_shallow): Use pulongest to print dwarf_block.size. Siddhesh> (decode_locdesc): Expand SIZE and I to size_t. Ok. Tom