From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [COMMIT PATCH] More invalid pointer to pointer conversions.
Date: Wed, 13 Mar 2013 17:38:00 -0000 [thread overview]
Message-ID: <87r4jjb3p7.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20130313164801.25932.31237.stgit@brno.lan> (Pedro Alves's message of "Wed, 13 Mar 2013 16:48:01 +0000")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> I think the ada_decode_symbol change is perhaps the one that could be
Pedro> surprising.
The obj_section removal series tripped over this too :)
Pedro> With that out of the way, I think the patch ends up being pretty
Pedro> obvious.
I agree, looks good to me.
Pedro> - displacement = strtol (tmp, (char **) &tmp, 10);
Pedro> + displacement = strtol (tmp, &endp, 10);
Pedro> + tmp = endp;
I saw this in Keith's patch, too, and I was wondering if we should have
a strtol_const convenience function.
Tom
next prev parent reply other threads:[~2013-03-13 17:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 16:48 Pedro Alves
2013-03-13 17:38 ` Tom Tromey [this message]
2013-03-13 17:55 ` Pedro Alves
2013-03-13 21:52 ` Pedro Alves
2013-03-14 17:56 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4jjb3p7.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox