Re: [COMMIT PATCH] More invalid pointer to pointer conversions.

Tom Tromey
2013-03-13T17:38:21Z

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> I think the ada_decode_symbol change is perhaps the one that could be
Pedro> surprising.

The obj_section removal series tripped over this too :)

Pedro> With that out of the way, I think the patch ends up being pretty
Pedro> obvious.

I agree, looks good to me.

Pedro> - displacement = strtol (tmp, (char **) &tmp, 10);
Pedro> + displacement = strtol (tmp, &endp, 10);
Pedro> + tmp = endp;

I saw this in Keith's patch, too, and I was wondering if we should have
a strtol_const convenience function.

Tom