Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [COMMIT PATCH] More invalid pointer to pointer conversions.
Date: Thu, 14 Mar 2013 17:56:00 -0000	[thread overview]
Message-ID: <87boal7tng.fsf@fleche.redhat.com> (raw)
In-Reply-To: <5140F4F9.9050000@redhat.com> (Pedro Alves's message of "Wed, 13	Mar 2013 21:51:53 +0000")

Pedro> Perhaps instead we should either fix all the strtol
Pedro> call sites for error handling, or even come up with
Pedro> (a) throwing variant(s).  See e.g.,
Pedro> xml_parse_unsigned_integer and gdb_xml_parse_ulongest
Pedro> for possible interfaces.  (I note ERANGE handling is
Pedro> missing there too).

Yeah, I think a checking version would be an improvement.

Tom


      reply	other threads:[~2013-03-14 17:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-13 16:48 Pedro Alves
2013-03-13 17:38 ` Tom Tromey
2013-03-13 17:55   ` Pedro Alves
2013-03-13 21:52     ` Pedro Alves
2013-03-14 17:56       ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87boal7tng.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox