From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13207 invoked by alias); 14 Mar 2013 17:56:02 -0000 Received: (qmail 13195 invoked by uid 22791); 14 Mar 2013 17:56:00 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Mar 2013 17:55:49 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2EHtmGv011098 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 14 Mar 2013 13:55:48 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r2EHtlkZ025033 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 14 Mar 2013 13:55:48 -0400 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [COMMIT PATCH] More invalid pointer to pointer conversions. References: <20130313164801.25932.31237.stgit@brno.lan> <87r4jjb3p7.fsf@fleche.redhat.com> <5140BD84.7080708@redhat.com> <5140F4F9.9050000@redhat.com> Date: Thu, 14 Mar 2013 17:56:00 -0000 In-Reply-To: <5140F4F9.9050000@redhat.com> (Pedro Alves's message of "Wed, 13 Mar 2013 21:51:53 +0000") Message-ID: <87boal7tng.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00644.txt.bz2 Pedro> Perhaps instead we should either fix all the strtol Pedro> call sites for error handling, or even come up with Pedro> (a) throwing variant(s). See e.g., Pedro> xml_parse_unsigned_integer and gdb_xml_parse_ulongest Pedro> for possible interfaces. (I note ERANGE handling is Pedro> missing there too). Yeah, I think a checking version would be an improvement. Tom