From: Tom Tromey <tom@tromey.com>
To: Manish Goregaokar <manish@mozilla.com>
Cc: gdb-patches@sourceware.org, Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH] Allow subscripting raw pointers
Date: Tue, 05 Jul 2016 17:20:00 -0000 [thread overview]
Message-ID: <87r3b8gfyd.fsf@tromey.com> (raw)
In-Reply-To: <CAFOnWknrO_Gtgj+k_foXMJk3UkzRtdq7WgzENZ4cPf2bRUv8RA@mail.gmail.com> (Manish Goregaokar's message of "Mon, 4 Jul 2016 18:12:18 +0530")
>>>>> "Manish" == Manish Goregaokar <manish@mozilla.com> writes:
Manish> 2016-07-04 Manish Goregaokar <manish@mozilla.com>
Manish> gdb/ChangeLog:
Manish> * rust-lang.c (rust_subscript): Allow subscripting pointers
Manish> gdb/testsuite/ChangeLog:
Manish> * simple.rs: Add test for raw pointer subscripting
Manish> * simple.exp: Add test expectations
This is ok. Thanks.
Manish> + else if (TYPE_CODE (type) == TYPE_CODE_PTR)
Manish> + {
Manish> + base = lhs;
Manish> + low_bound = 0;
Manish> + high_bound = LONGEST_MAX;
Manish> + }
Manish> else
I suspect maybe your MUA is misconfigured somehow? Your patches often
come out looking like the indentation is messed up; but in this case the
context makes it clear that the indentation is probably ok.
Tom
next prev parent reply other threads:[~2016-07-05 17:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 12:42 Manish Goregaokar
2016-07-05 17:20 ` Tom Tromey [this message]
2016-07-05 17:32 ` Manish Goregaokar
2016-07-05 17:39 ` Trevor Saunders
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3b8gfyd.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=manish@mozilla.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox