From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127457 invoked by alias); 5 Jul 2016 17:20:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127448 invoked by uid 89); 5 Jul 2016 17:20:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=misconfigured, H*MI:tromey, H*M:tromey, H*F:U*tom X-HELO: gproxy10-pub.mail.unifiedlayer.com Received: from gproxy10-pub.mail.unifiedlayer.com (HELO gproxy10-pub.mail.unifiedlayer.com) (69.89.20.226) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Tue, 05 Jul 2016 17:20:05 +0000 Received: (qmail 27530 invoked by uid 0); 5 Jul 2016 17:20:02 -0000 Received: from unknown (HELO cmgw2) (10.0.90.83) by gproxy10.mail.unifiedlayer.com with SMTP; 5 Jul 2016 17:20:02 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id F5Kv1t00l2f2jeq015KyX8; Tue, 05 Jul 2016 11:20:00 -0600 X-Authority-Analysis: v=2.1 cv=ff4+lSgF c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=PnD2wP_eR3oA:10 a=7XZj0uCbPdcA:10 a=cAmyUtKerLwA:10 a=BzObnAOqAAAA:8 a=3URnQ0ZcEG1f6kAjBBEA:9 a=PuSIgb6VMkSJ0_1bSHE4:22 Received: from [75.171.172.174] (port=41656 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_2) (envelope-from ) id 1bKU0r-000639-5B; Tue, 05 Jul 2016 11:19:57 -0600 From: Tom Tromey To: Manish Goregaokar Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH] Allow subscripting raw pointers References: Date: Tue, 05 Jul 2016 17:20:00 -0000 In-Reply-To: (Manish Goregaokar's message of "Mon, 4 Jul 2016 18:12:18 +0530") Message-ID: <87r3b8gfyd.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {36111:box522.bluehost.com:elynrobi:tromey.com} {sentby:smtp auth 75.171.172.174 authed with tom+tromey.com} X-Exim-ID: 1bKU0r-000639-5B X-Source-Sender: (pokyo) [75.171.172.174]:41656 X-Source-Auth: tom+tromey.com X-Email-Count: 0 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-07/txt/msg00078.txt.bz2 >>>>> "Manish" == Manish Goregaokar writes: Manish> 2016-07-04 Manish Goregaokar Manish> gdb/ChangeLog: Manish> * rust-lang.c (rust_subscript): Allow subscripting pointers Manish> gdb/testsuite/ChangeLog: Manish> * simple.rs: Add test for raw pointer subscripting Manish> * simple.exp: Add test expectations This is ok. Thanks. Manish> + else if (TYPE_CODE (type) == TYPE_CODE_PTR) Manish> + { Manish> + base = lhs; Manish> + low_bound = 0; Manish> + high_bound = LONGEST_MAX; Manish> + } Manish> else I suspect maybe your MUA is misconfigured somehow? Your patches often come out looking like the indentation is messed up; but in this case the context makes it clear that the indentation is probably ok. Tom