Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Manish Goregaokar <manish@mozilla.com>
To: gdb-patches@sourceware.org, Tom Tromey <tom@tromey.com>
Subject: [PATCH] Allow subscripting raw pointers
Date: Mon, 04 Jul 2016 12:42:00 -0000	[thread overview]
Message-ID: <CAFOnWknrO_Gtgj+k_foXMJk3UkzRtdq7WgzENZ4cPf2bRUv8RA@mail.gmail.com> (raw)

This will be useful for dealing with vectors; regardless of our final solution
for the Index trait.

Right now subscripting vectors requires dancing between C and Rust mode.

2016-07-04  Manish Goregaokar  <manish@mozilla.com>

gdb/ChangeLog:
    * rust-lang.c (rust_subscript): Allow subscripting pointers

gdb/testsuite/ChangeLog:
    * simple.rs: Add test for raw pointer subscripting
    * simple.exp: Add test expectations
---
 gdb/rust-lang.c                   | 6 ++++++
 gdb/testsuite/gdb.rust/simple.exp | 1 +
 gdb/testsuite/gdb.rust/simple.rs  | 1 +
 3 files changed, 8 insertions(+)

diff --git a/gdb/rust-lang.c b/gdb/rust-lang.c
index 1849349..17b20c6 100644
--- a/gdb/rust-lang.c
+++ b/gdb/rust-lang.c
@@ -1415,6 +1415,12 @@ rust_subscript (struct expression *exp, int
*pos, enum noside noside,
       low_bound = 0;
       high_bound = value_as_long (len);
     }
+      else if (TYPE_CODE (type) == TYPE_CODE_PTR)
+    {
+      base = lhs;
+      low_bound = 0;
+      high_bound = LONGEST_MAX;
+    }
       else
     error (_("Cannot subscript non-array type"));

diff --git a/gdb/testsuite/gdb.rust/simple.exp
b/gdb/testsuite/gdb.rust/simple.exp
index 4622f75..32b3785 100644
--- a/gdb/testsuite/gdb.rust/simple.exp
+++ b/gdb/testsuite/gdb.rust/simple.exp
@@ -73,6 +73,7 @@ gdb_test "print w" " = \\\[1, 2, 3, 4\\\]"
 gdb_test "ptype w" " = \\\[i32; 4\\\]"
 gdb_test "print w\[2\]" " = 3"
 gdb_test "print w\[2\] @ 2" " = \\\[3, 4\\\]"
+gdb_test "print w_ptr\[2\]" " = 3"
 gdb_test "print fromslice" " = 3"
 gdb_test "print slice\[0\]" " = 3"
 gdb_test "print slice as &\[i32\]\[0\]" " = 3"
diff --git a/gdb/testsuite/gdb.rust/simple.rs b/gdb/testsuite/gdb.rust/simple.rs
index 3d28e27..4980826 100644
--- a/gdb/testsuite/gdb.rust/simple.rs
+++ b/gdb/testsuite/gdb.rust/simple.rs
@@ -87,6 +87,7 @@ fn main () {

     let v = Something::Three;
     let w = [1,2,3,4];
+    let w_ptr = &w[0];
     let x = (23, 25.5);
     let y = HiBob {field1: 7, field2: 8};
     let z = ByeBob(7, 8);
-- 
2.8.3


             reply	other threads:[~2016-07-04 12:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-04 12:42 Manish Goregaokar [this message]
2016-07-05 17:20 ` Tom Tromey
2016-07-05 17:32   ` Manish Goregaokar
2016-07-05 17:39     ` Trevor Saunders

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFOnWknrO_Gtgj+k_foXMJk3UkzRtdq7WgzENZ4cPf2bRUv8RA@mail.gmail.com \
    --to=manish@mozilla.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox