Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Have partial symbol tables own psymbol vectors
Date: Sat, 17 Oct 2020 16:33:13 -0600	[thread overview]
Message-ID: <87r1pwcwk6.fsf@tromey.com> (raw)
In-Reply-To: <b0b5e24e-2ba8-66bd-e826-5b0483d311b2@simark.ca> (Simon Marchi's message of "Mon, 31 Aug 2020 17:39:39 -0400")

Simon> I think it would be a good time to get rid of the objfile
Simon> parameter in the add_psymbol methods.  This parameter shouldn't
Simon> be there if the partial symtabs are really objfile-independent.

I looked at this again today.  It's pretty easy to get rid of most of
the uses of the objfile, but the last one is a bit of a pain:

  psymbol.ginfo.compute_and_set_names (name, copy_name, objfile->per_bfd);

I suppose we could pass in the per-BFD object.  And maybe I will do this
... not sure.  It just feels a bit weird since it means we'd have to
pass in two "context" objects where really just one would do.

I suppose the deeper problem here is that while psymbols are
objfile-independent, we don't genuinely implement sharing anywhere
except DWARF -- that's the only reader where we did the work of making
sure any auxiliary data is also shareable.

Tom

  parent reply	other threads:[~2020-10-17 22:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-28 19:33 Tom Tromey
2020-08-30 19:18 ` Tom Tromey
2020-08-31 17:09   ` Tom Tromey
2020-08-31 21:39     ` Simon Marchi
2020-09-01 14:23       ` Tom Tromey
2020-09-01 14:28         ` Simon Marchi
2020-10-17 22:33       ` Tom Tromey [this message]
2020-09-01 13:24     ` Simon Marchi
2020-09-01 14:20       ` Tom Tromey
2020-09-01 14:30         ` Simon Marchi
2020-09-01 14:41     ` Simon Marchi
2020-09-01 17:59       ` Tom Tromey
2020-10-17 20:17     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1pwcwk6.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox