From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Have partial symbol tables own psymbol vectors
Date: Tue, 01 Sep 2020 11:59:02 -0600 [thread overview]
Message-ID: <87d0357509.fsf@tromey.com> (raw)
In-Reply-To: <74b64278-9789-9130-13fb-c722b06c09a9@simark.ca> (Simon Marchi's message of "Tue, 1 Sep 2020 10:41:02 -0400")
>> @@ -1666,16 +1605,6 @@ add_psymbol_to_list (gdb::string_view name, bool copy_name,
>> void
>> init_psymbol_list (struct objfile *objfile, int total_symbols)
>> {
>> - if (objfile->partial_symtabs->global_psymbols.capacity () == 0
>> - && objfile->partial_symtabs->static_psymbols.capacity () == 0)
>> - {
>> - /* Current best guess is that approximately a twentieth of the
>> - total symbols (in a debugging file) are global or static
>> - oriented symbols, then multiply that by slop factor of
>> - two. */
>> - objfile->partial_symtabs->global_psymbols.reserve (total_symbols / 10);
>> - objfile->partial_symtabs->static_psymbols.reserve (total_symbols / 10);
>> - }
>> }
Simon> Did you keep this empty function on purpose?
I wasn't sure if I'd want to introduce some kind of psymtab builder RAII
thing, and the calls to this function would mark the needed spots.
That said, I do have a separate patch somewhere to remove it. I can
submit it. I don't think I ended up needing the builder thing.
I did experiment with sorting psymbols in the background, but on this
machine at least it didn't help. However I suspect maybe it would help
on a more capable machine -- I plan to try it on my work computer soon.
(I've also got a bigger series to try reading each CU in parallel, but
that is unfinished due to some complexity with cross-CU references.)
Tom
next prev parent reply other threads:[~2020-09-01 17:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 19:33 Tom Tromey
2020-08-30 19:18 ` Tom Tromey
2020-08-31 17:09 ` Tom Tromey
2020-08-31 21:39 ` Simon Marchi
2020-09-01 14:23 ` Tom Tromey
2020-09-01 14:28 ` Simon Marchi
2020-10-17 22:33 ` Tom Tromey
2020-09-01 13:24 ` Simon Marchi
2020-09-01 14:20 ` Tom Tromey
2020-09-01 14:30 ` Simon Marchi
2020-09-01 14:41 ` Simon Marchi
2020-09-01 17:59 ` Tom Tromey [this message]
2020-10-17 20:17 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0357509.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox