From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SIFCOi9xi1+wFAAAWB0awg (envelope-from ) for ; Sat, 17 Oct 2020 18:33:19 -0400 Received: by simark.ca (Postfix, from userid 112) id EC26D1EF6F; Sat, 17 Oct 2020 18:33:19 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 73E131E58E for ; Sat, 17 Oct 2020 18:33:19 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B6C793857800; Sat, 17 Oct 2020 22:33:18 +0000 (GMT) Received: from gateway31.websitewelcome.com (gateway31.websitewelcome.com [192.185.143.36]) by sourceware.org (Postfix) with ESMTPS id 8D8C33857800 for ; Sat, 17 Oct 2020 22:33:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8D8C33857800 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 142D21A9FAC7 for ; Sat, 17 Oct 2020 17:33:15 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id TulHkiqxdCjCVTulHk2Tkw; Sat, 17 Oct 2020 17:33:15 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uSKnoFE9RVXTeUkjNfB4DesSRPhjIoHyvgucafkEdrs=; b=CPh/8HFpGpw0rn6bROtXH+8Vhc 8ho4cZUN6G0/nxlqSCM3mL7O8sd3LdiHagnQocYcAkkgiZ6NWmbbFxSIv7eoXRhA/wCWOI57azZrz 2QkIXqKuzngwj2B1JRJuoatE6; Received: from 75-166-102-113.hlrn.qwest.net ([75.166.102.113]:48026 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kTulG-004ERL-P9; Sat, 17 Oct 2020 16:33:14 -0600 From: Tom Tromey To: Simon Marchi Subject: Re: [PATCH] Have partial symbol tables own psymbol vectors References: <20200828193304.17475-1-tom@tromey.com> <871rjo7xic.fsf@tromey.com> <87sgc27nez.fsf@tromey.com> X-Attribution: Tom Date: Sat, 17 Oct 2020 16:33:13 -0600 In-Reply-To: (Simon Marchi's message of "Mon, 31 Aug 2020 17:39:39 -0400") Message-ID: <87r1pwcwk6.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.102.113 X-Source-L: No X-Exim-ID: 1kTulG-004ERL-P9 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-102-113.hlrn.qwest.net (bapiya) [75.166.102.113]:48026 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Simon> I think it would be a good time to get rid of the objfile Simon> parameter in the add_psymbol methods. This parameter shouldn't Simon> be there if the partial symtabs are really objfile-independent. I looked at this again today. It's pretty easy to get rid of most of the uses of the objfile, but the last one is a bit of a pain: psymbol.ginfo.compute_and_set_names (name, copy_name, objfile->per_bfd); I suppose we could pass in the per-BFD object. And maybe I will do this ... not sure. It just feels a bit weird since it means we'd have to pass in two "context" objects where really just one would do. I suppose the deeper problem here is that while psymbols are objfile-independent, we don't genuinely implement sharing anywhere except DWARF -- that's the only reader where we did the work of making sure any auxiliary data is also shareable. Tom