Re: [PATCH v2] gdb, testsuite: fix gdb.base/save-history.exp for native-extended-gdbserver

[Tom Tromey <tom@tromey.com>]

>>>>> Tankut Baris Aktemur <tankut.baris.aktemur@intel.com> writes:

> This revision addresses Guinevere's review comment and does not skip
> the test when the target is extended-remote.

This is ok.
Approved-By: Tom Tromey <tom@tromey.com>

>  set expected "set height 0\n"
>  append expected "set width 0\n"
> +
> +# There is an additional target connection command with the
> +# extended-remote board file.
> +if {[target_info gdb_protocol] == "extended-remote"} {
> +    append expected "target extended-remote $gdbserver_gdbport\n"
> +}

No need to spend more time on this, but it seems like there could be
other target boards that add other commands, or we may conceivably add
commands to the test suite prologue, and what would really be nice is
something a bit more robust.  But OTOH it seems like a lot of work for
something pretty marginal.

Tom