From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id dAS5JW/I8GlrLQEAWB0awg (envelope-from ) for ; Tue, 28 Apr 2026 10:47:11 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=yNJNBHFq; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8CB941E0BA; Tue, 28 Apr 2026 10:47:11 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 166C41E067 for ; Tue, 28 Apr 2026 10:47:11 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 4BF604BA901D for ; Tue, 28 Apr 2026 14:47:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4BF604BA901D Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=yNJNBHFq Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 903F54BA901D for ; Tue, 28 Apr 2026 14:46:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 903F54BA901D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 903F54BA901D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777387605; cv=none; b=t3ENSqjCQbaoIfgoeN9qeh35ii6vwi+f8cYNwVai02R+lr5qTQb5v7rWpHFQFIMaHberePrFUFME9xvkVNJbxUmmqA9bCpFpm3KG/jG8bu2V5jd56pZRm7VYRW1I05XUKGfd5N879cqWqIJB8oH324yJL2aMODt5ugnB9WMGfq4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777387605; c=relaxed/simple; bh=3fvkNxBztX5tv9aK2aHaUdoo5mhe8HQs2bENtbNp2s0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=QCq7QincoJdveh5vjyxRo1e8nZNRt1LruPQ3cce7EHOGUgAaHxZD5I21wPvnrE/1QFq8RMWBlb6Jqj0YWwluJsHKmzx56zfR6+c/F8h3rTfeLUuwTIT7pIoEQzraof6HkN9+vz4f8+ibl3mu20S2CFBaKrVVMbsHfXiYz3mZ+/M= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 903F54BA901D Received: from eig-obgw-5001b.ext.cloudfilter.net ([10.0.29.181]) by cmsmtp with ESMTPS id HUvswmx7krDqVHji0w1Yu4; Tue, 28 Apr 2026 14:46:44 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Hjhxw0dfnI7vWHjhxwYH08; Tue, 28 Apr 2026 14:46:41 +0000 X-Authority-Analysis: v=2.4 cv=T6WMT+KQ c=1 sm=1 tr=0 ts=69f0c854 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=A5OVakUREuEA:10 a=ItBw4LHWJt0A:10 a=QyXUC8HyAAAA:8 a=zstS-IiYAAAA:8 a=n4xGzGqL4X6JbHuXukgA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=dtcNoyXBKyhR/6BVQ2xvyZAncmALZUixt91HVi3TP6g=; b=yNJNBHFqikhtTZIBVtP+12DLSw lpnC8ZkJVf9z9hKTF6WvXq+ubFjjzlkrPkXghtkzfvgNTgkRyuE+PqIb1/cAzyU1U7Kzy3aTvu7Lh w6Pi4id1xjuiWnlXwrOESDjGv; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:38828 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wHjhw-00000001a4o-3XsF; Tue, 28 Apr 2026 08:46:40 -0600 From: Tom Tromey To: Tankut Baris Aktemur Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] gdb, testsuite: fix gdb.base/save-history.exp for native-extended-gdbserver In-Reply-To: <20260420080758.1134782-1-tankut.baris.aktemur@intel.com> (Tankut Baris Aktemur's message of "Mon, 20 Apr 2026 10:07:58 +0200") References: <20260420080758.1134782-1-tankut.baris.aktemur@intel.com> X-Attribution: Tom Date: Tue, 28 Apr 2026 08:46:38 -0600 Message-ID: <87qznzm9bl.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wHjhw-00000001a4o-3XsF X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:38828 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHitGsEReyf9RomGXR0TD0SajVN/sxPyECn0L37aYdremMmPb459b9S4C9N7mo87AbcXKaPcp+ctJIGyPGJVZQhqdYHWOqCSlX+3cBDk1uL7PhXz64Yu zkBWRDFZSuKQ+25Z+Jc5PpWYPAWMjwZueEAkjO4e1i8vlN4hVyWYr+1+TyYOG+I0JnPpTuEb1F7eV2hNN6ZsaOfnYVbZLlQ49Zw= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> Tankut Baris Aktemur writes: > This revision addresses Guinevere's review comment and does not skip > the test when the target is extended-remote. This is ok. Approved-By: Tom Tromey > set expected "set height 0\n" > append expected "set width 0\n" > + > +# There is an additional target connection command with the > +# extended-remote board file. > +if {[target_info gdb_protocol] == "extended-remote"} { > + append expected "target extended-remote $gdbserver_gdbport\n" > +} No need to spend more time on this, but it seems like there could be other target boards that add other commands, or we may conceivably add commands to the test suite prologue, and what would really be nice is something a bit more robust. But OTOH it seems like a lot of work for something pretty marginal. Tom