Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
To: gdb-patches@sourceware.org
Subject: [PATCH v2] gdb, testsuite: fix gdb.base/save-history.exp for native-extended-gdbserver
Date: Mon, 20 Apr 2026 10:07:58 +0200	[thread overview]
Message-ID: <20260420080758.1134782-1-tankut.baris.aktemur@intel.com> (raw)

This revision addresses Guinevere's review comment and does not skip
the test when the target is extended-remote.

Regards,
Baris

====

When executed with the native-extended-gdbserver board file, we get

  FAIL: gdb.base/save-history.exp: check history contents

This is because the history file contains an extra line for the
command 'target extended-remote ...'.  Address this in the test.
---
 gdb/testsuite/gdb.base/save-history.exp | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gdb/testsuite/gdb.base/save-history.exp b/gdb/testsuite/gdb.base/save-history.exp
index bb7a56b2a72..afdd5f696a0 100644
--- a/gdb/testsuite/gdb.base/save-history.exp
+++ b/gdb/testsuite/gdb.base/save-history.exp
@@ -30,6 +30,13 @@ gdb_test_no_output "save history $filename" \
 
 set expected "set height 0\n"
 append expected "set width 0\n"
+
+# There is an additional target connection command with the
+# extended-remote board file.
+if {[target_info gdb_protocol] == "extended-remote"} {
+    append expected "target extended-remote $gdbserver_gdbport\n"
+}
+
 append expected "print 23\n"
 append expected "save history $filename\n"
 
-- 
2.34.1

Intel Deutschland GmbH
Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany
Tel: +49 89 991 430, www.intel.de
Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell
Chairperson of the Supervisory Board: Nicole Lau
Registered Seat: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


             reply	other threads:[~2026-04-20  8:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20  8:07 Tankut Baris Aktemur [this message]
2026-04-28 14:46 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260420080758.1134782-1-tankut.baris.aktemur@intel.com \
    --to=tankut.baris.aktemur@intel.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox