From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id XcOPJ1ff5WmAiisAWB0awg (envelope-from ) for ; Mon, 20 Apr 2026 04:09:59 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=QdantPeT; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7DA7D1E067; Mon, 20 Apr 2026 04:09:59 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8BA1E1E067 for ; Mon, 20 Apr 2026 04:09:57 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 9C74A4BC0577 for ; Mon, 20 Apr 2026 08:09:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9C74A4BC0577 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=QdantPeT Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by sourceware.org (Postfix) with ESMTPS id 47B2F4C900E9 for ; Mon, 20 Apr 2026 08:08:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 47B2F4C900E9 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 47B2F4C900E9 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=192.198.163.19 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776672494; cv=none; b=qEbaRpIza2gKwSjJ60agi47F4iCyMo+WYzDhHx1gRsDDPCh4hie1veXElRTpFQs+DKvqlx/YBmhmclwhlx1YqliEPJQhcr+l0v9RB9oAeK09ObuvjE5OAxGrp0eKQ9aU+tXDhpn0Db1OrUMqiXWmfx6Tiwj2RQ1E3H7WlL4JhEA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776672494; c=relaxed/simple; bh=/4QGFsbCzbNRIA0N5EzX3C18vCqQk8cYgcYFfAsHH6Q=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=RW/8LY4OM/Sle8dbitBkZu3WbO+dtsqDHy7FeR1Yt4njR8ZyK5R2H0NgrhLA2EOR04i8ZeFDKbKv0PyQamYMjzzNxeuhu/hhV2s5cP1YUCbbnLuUytn85TIcFnpmXApM9YraYCjECF3914xGlMxvnva+6KoqsT/2mH0ccm1s0r8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 47B2F4C900E9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1776672494; x=1808208494; h=from:to:subject:date:message-id:mime-version: content-transfer-encoding; bh=/4QGFsbCzbNRIA0N5EzX3C18vCqQk8cYgcYFfAsHH6Q=; b=QdantPeTutxqGm+Vp+qdcDE8aPpQJkNt4sKMX3vRc80Gngqty8U7+6CK 1W03oS86puT1Y7KpHEpI5CV5V1enMiHvgtMJB72Wa0WlV6a3b3u+drmW6 1PqjSDhjavDowJ9b1VignAAaYfpHqY6enP+J5ijS26Bmu7K8hT8kwS5RN 3uP9XwGB2DZCIBgrU91Zan+St6WnlNi2eNe4l5vkr4kUgJVBwp1Xrfpp9 ikFs9NN90hUByDeJ7n7+gtdgpbvlPhVYh5V50CVRJbkmHSuhr6HdyTGDD 2AGugdr9QhCwm27PRbn39AiqeqMaliM2kuUAi4z6COQVkQBzKmBv8vG+h Q==; X-CSE-ConnectionGUID: M5zSB6KVSOWx3vNfit9RNg== X-CSE-MsgGUID: nOWLVcoGTCSWCUyQpSoxeQ== X-IronPort-AV: E=McAfee;i="6800,10657,11762"; a="76609649" X-IronPort-AV: E=Sophos;i="6.23,189,1770624000"; d="scan'208";a="76609649" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2026 01:08:13 -0700 X-CSE-ConnectionGUID: 0UFW1OpjSVyxmVaMK/cVpg== X-CSE-MsgGUID: qHSVGxNfQ5CkqyB4GoOPvg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,189,1770624000"; d="scan'208";a="236636573" Received: from gkldtt-dev-004.igk.intel.com (HELO localhost) ([10.123.221.202]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2026 01:08:12 -0700 From: Tankut Baris Aktemur To: gdb-patches@sourceware.org Subject: [PATCH v2] gdb, testsuite: fix gdb.base/save-history.exp for native-extended-gdbserver Date: Mon, 20 Apr 2026 10:07:58 +0200 Message-Id: <20260420080758.1134782-1-tankut.baris.aktemur@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This revision addresses Guinevere's review comment and does not skip the test when the target is extended-remote. Regards, Baris ==== When executed with the native-extended-gdbserver board file, we get FAIL: gdb.base/save-history.exp: check history contents This is because the history file contains an extra line for the command 'target extended-remote ...'. Address this in the test. --- gdb/testsuite/gdb.base/save-history.exp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/gdb/testsuite/gdb.base/save-history.exp b/gdb/testsuite/gdb.base/save-history.exp index bb7a56b2a72..afdd5f696a0 100644 --- a/gdb/testsuite/gdb.base/save-history.exp +++ b/gdb/testsuite/gdb.base/save-history.exp @@ -30,6 +30,13 @@ gdb_test_no_output "save history $filename" \ set expected "set height 0\n" append expected "set width 0\n" + +# There is an additional target connection command with the +# extended-remote board file. +if {[target_info gdb_protocol] == "extended-remote"} { + append expected "target extended-remote $gdbserver_gdbport\n" +} + append expected "print 23\n" append expected "save history $filename\n" -- 2.34.1 Intel Deutschland GmbH Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany Tel: +49 89 991 430, www.intel.de Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell Chairperson of the Supervisory Board: Nicole Lau Registered Seat: Munich Commercial Register: Amtsgericht Muenchen HRB 186928