From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA v3 07/13] Throw a "quit" on a KeyboardException in py-framefilter.c
Date: Sun, 25 Mar 2018 16:37:00 -0000 [thread overview]
Message-ID: <87po3saz6r.fsf@tromey.com> (raw)
In-Reply-To: <43b0c215-f754-a4e5-d39d-9d9e5ed30990@redhat.com> (Pedro Alves's message of "Sat, 24 Mar 2018 11:41:34 +0000")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> On 03/23/2018 08:55 PM, Tom Tromey wrote:
>> +set test "bt 1 with KeyboardInterrupt"
>> +gdb_test_multiple "bt 1" $test {
>> + -re "Quit" {
>> + pass $test
>> + }
>> +}
Pedro> What's the gdb output in gdb.log in this case? Is there a GDB prompt
Pedro> involved?
Here's what gdb.log says:
bt 1
#0 Quit
(gdb) PASS: gdb.python/py-framefilter.exp: bt 1 with KeyboardInterrupt
The test is making a frame filter that throws a KeyboardInterrupt when
called, to simulate the user interrupting the backtrace.
Pedro> I'm wondering whether this is racy as is. Does e.g., the test pass
Pedro> with "make check-read1"?
This works fine.
Pedro> Or, are we leaving a gdb prompt in the expect buffer unprocessed?
I don't think so but I guess I am not really sure.
Tom
next prev parent reply other threads:[~2018-03-25 16:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 20:55 [RFA v3 00/13] various frame filter fixes and cleanups Tom Tromey
2018-03-23 20:55 ` [RFA v3 02/13] Change backtrace_command_1 calling to use flags Tom Tromey
2018-03-23 20:55 ` [RFA v3 05/13] Avoid manual resource management in py-framefilter.c Tom Tromey
2018-03-23 20:55 ` [RFA v3 07/13] Throw a "quit" on a KeyboardException " Tom Tromey
2018-03-24 11:41 ` Pedro Alves
2018-03-25 16:37 ` Tom Tromey [this message]
2018-03-25 17:13 ` Pedro Alves
2018-03-26 21:14 ` Tom Tromey
2018-03-23 20:55 ` [RFA v3 06/13] Allow C-c to work in backtrace in more cases Tom Tromey
2018-03-23 20:55 ` [RFA v3 13/13] Remove verbose code from backtrace command Tom Tromey
2018-03-23 20:55 ` [RFA v3 11/13] Improve "backtrace" help text Tom Tromey
2018-03-23 20:55 ` [RFA v3 09/13] Return EXT_LANG_BT_ERROR in one more spot in py-framefilter.c Tom Tromey
2018-03-23 20:55 ` [RFA v3 01/13] Rationalize "backtrace" command line parsing Tom Tromey
2018-03-24 6:31 ` Eli Zaretskii
2018-03-25 16:50 ` Tom Tromey
2018-03-25 17:11 ` Eli Zaretskii
2018-03-26 20:45 ` Tom Tromey
2018-03-27 2:35 ` Eli Zaretskii
2018-03-23 20:55 ` [RFA v3 04/13] Remove EXT_LANG_BT_COMPLETED Tom Tromey
2018-03-23 20:55 ` [RFA v3 03/13] Allow hiding of some filtered frames Tom Tromey
2018-03-24 6:32 ` Eli Zaretskii
2018-03-23 20:55 ` [RFA v3 10/13] Call wrap_hint in one more spot in py-framefilter.c Tom Tromey
2018-03-23 20:55 ` [RFA v3 12/13] Simplify exception handling " Tom Tromey
2018-03-23 20:55 ` [RFA v3 08/13] Move some code later in backtrace_command_1 Tom Tromey
2018-03-24 11:42 ` [RFA v3 00/13] various frame filter fixes and cleanups Pedro Alves
2018-03-27 4:01 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87po3saz6r.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox