From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Subject: [RFA v3 00/13] various frame filter fixes and cleanups
Date: Fri, 23 Mar 2018 20:55:00 -0000 [thread overview]
Message-ID: <20180323205512.14434-1-tom@tromey.com> (raw)
This is version 3 of a series that I last sent last August:
https://sourceware.org/ml/gdb-patches/2017-08/msg00277.html
Most of the patches were already approved, though of course it doesn't
hurt to check again. At least patch #1 needed some reworking in order
to be rebased on top of the changes that have been made since August.
This version addresses most of the review comments from version 2.
Also, in response to Pedro's feedback about the choice of "elide" as
the option name, I've changed the new command to be "bt hide". I
think this should be unambiguous.
I have not addressed Phil's comments:
https://sourceware.org/ml/gdb-patches/2017-08/msg00360.html
https://sourceware.org/ml/gdb-patches/2017-08/msg00359.html
One reason is that I agree with Pedro's comment here:
https://sourceware.org/ml/gdb-patches/2017-08/msg00297.html
Another reason is that I think that the two ideas can live together,
if necessary: I'd still appreciate a way to hide frames from the
command line, overriding whatever individual frame filters think is
appropriate. Similarly, adding this feature to frame filters would
not impact this series -- it can always still be done after this.
Regression tested by the buildbot.
Tom
next reply other threads:[~2018-03-23 20:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 20:55 Tom Tromey [this message]
2018-03-23 20:55 ` [RFA v3 06/13] Allow C-c to work in backtrace in more cases Tom Tromey
2018-03-23 20:55 ` [RFA v3 13/13] Remove verbose code from backtrace command Tom Tromey
2018-03-23 20:55 ` [RFA v3 09/13] Return EXT_LANG_BT_ERROR in one more spot in py-framefilter.c Tom Tromey
2018-03-23 20:55 ` [RFA v3 11/13] Improve "backtrace" help text Tom Tromey
2018-03-23 20:55 ` [RFA v3 04/13] Remove EXT_LANG_BT_COMPLETED Tom Tromey
2018-03-23 20:55 ` [RFA v3 03/13] Allow hiding of some filtered frames Tom Tromey
2018-03-24 6:32 ` Eli Zaretskii
2018-03-23 20:55 ` [RFA v3 01/13] Rationalize "backtrace" command line parsing Tom Tromey
2018-03-24 6:31 ` Eli Zaretskii
2018-03-25 16:50 ` Tom Tromey
2018-03-25 17:11 ` Eli Zaretskii
2018-03-26 20:45 ` Tom Tromey
2018-03-27 2:35 ` Eli Zaretskii
2018-03-23 20:55 ` [RFA v3 12/13] Simplify exception handling in py-framefilter.c Tom Tromey
2018-03-23 20:55 ` [RFA v3 08/13] Move some code later in backtrace_command_1 Tom Tromey
2018-03-23 20:55 ` [RFA v3 10/13] Call wrap_hint in one more spot in py-framefilter.c Tom Tromey
2018-03-23 20:55 ` [RFA v3 05/13] Avoid manual resource management " Tom Tromey
2018-03-23 20:55 ` [RFA v3 02/13] Change backtrace_command_1 calling to use flags Tom Tromey
2018-03-23 20:55 ` [RFA v3 07/13] Throw a "quit" on a KeyboardException in py-framefilter.c Tom Tromey
2018-03-24 11:41 ` Pedro Alves
2018-03-25 16:37 ` Tom Tromey
2018-03-25 17:13 ` Pedro Alves
2018-03-26 21:14 ` Tom Tromey
2018-03-24 11:42 ` [RFA v3 00/13] various frame filter fixes and cleanups Pedro Alves
2018-03-27 4:01 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180323205512.14434-1-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox