From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59871 invoked by alias); 25 Mar 2018 16:37:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59854 invoked by uid 89); 25 Mar 2018 16:37:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=What's, Hx-languages-length:904 X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 25 Mar 2018 16:37:52 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 4C1B3400CE386 for ; Sun, 25 Mar 2018 11:37:51 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 08eVfkyea7Ovo08eVf5sFJ; Sun, 25 Mar 2018 11:37:51 -0500 Received: from c-67-176-62-53.hsd1.co.comcast.net ([67.176.62.53]:54938 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1f08eU-004Hjd-Uh; Sun, 25 Mar 2018 11:37:51 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA v3 07/13] Throw a "quit" on a KeyboardException in py-framefilter.c In-Reply-To: <43b0c215-f754-a4e5-d39d-9d9e5ed30990@redhat.com> (Pedro Alves's message of "Sat, 24 Mar 2018 11:41:34 +0000") References: <20180323205512.14434-1-tom@tromey.com> <20180323205512.14434-8-tom@tromey.com> <43b0c215-f754-a4e5-d39d-9d9e5ed30990@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) Date: Sun, 25 Mar 2018 16:37:00 -0000 Message-ID: <87po3saz6r.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1f08eU-004Hjd-Uh X-Source-Sender: c-67-176-62-53.hsd1.co.comcast.net (bapiya) [67.176.62.53]:54938 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-03/txt/msg00500.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> On 03/23/2018 08:55 PM, Tom Tromey wrote: >> +set test "bt 1 with KeyboardInterrupt" >> +gdb_test_multiple "bt 1" $test { >> + -re "Quit" { >> + pass $test >> + } >> +} Pedro> What's the gdb output in gdb.log in this case? Is there a GDB prompt Pedro> involved? Here's what gdb.log says: bt 1 #0 Quit (gdb) PASS: gdb.python/py-framefilter.exp: bt 1 with KeyboardInterrupt The test is making a frame filter that throws a KeyboardInterrupt when called, to simulate the user interrupting the backtrace. Pedro> I'm wondering whether this is racy as is. Does e.g., the test pass Pedro> with "make check-read1"? This works fine. Pedro> Or, are we leaving a gdb prompt in the expect buffer unprocessed? I don't think so but I guess I am not really sure. Tom