Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org>
Cc: Lancelot SIX <lsix@lancelotsix.com>
Subject: Re: [PATCH][PR gdb/27133] Avoid use after free with logging and debug redirect
Date: Mon, 04 Jan 2021 13:26:20 -0700	[thread overview]
Message-ID: <87pn2ke9eb.fsf@tromey.com> (raw)
In-Reply-To: <20210101201127.20835-1-lsix@lancelotsix.com> (Lancelot SIX via Gdb-patches's message of "Fri, 1 Jan 2021 20:11:28 +0000")

>>>>> "Lancelot" == Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org> writes:

Lancelot> My copyright assignment has not yet been signed by FSF, but the change
Lancelot> should be small enough not to require it. Otherwise, it will need to
Lancelot> wait a few more days I guess.

I don't know the state of this -- could you say?

Lancelot> gdb/ChangeLog:

Lancelot> 	PR gdb/27133
Lancelot> 	* cli/cli-interp.c (cli_interp_base::set_logging): Ensure the
Lancelot> 	unique_ptr is released when the wrapped pointer is kept for later
Lancelot> 	use.

Thanks.  Looking at the code I feel like there's probably some cleaner
way to do this, but this patch is ok regardless.

Tom

  reply	other threads:[~2021-01-04 20:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-01 20:11 Lancelot SIX via Gdb-patches
2021-01-04 20:26 ` Tom Tromey [this message]
2021-01-04 23:29   ` Lancelot SIX via Gdb-patches
2021-01-27 22:20   ` Lancelot SIX via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pn2ke9eb.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lsix@lancelotsix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox