Re: [PATCH][PR gdb/27133] Avoid use after free with logging and debug redirect

[Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org>]

Le Mon, Jan 04, 2021 at 01:26:20PM -0700, Tom Tromey a écrit :
> >>>>> "Lancelot" == Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Lancelot> My copyright assignment has not yet been signed by FSF, but the change
> Lancelot> should be small enough not to require it. Otherwise, it will need to
> Lancelot> wait a few more days I guess.
> 
> I don't know the state of this -- could you say?
> 
> Lancelot> gdb/ChangeLog:
> 
> Lancelot> 	PR gdb/27133
> Lancelot> 	* cli/cli-interp.c (cli_interp_base::set_logging): Ensure the
> Lancelot> 	unique_ptr is released when the wrapped pointer is kept for later
> Lancelot> 	use.
> 
> Thanks.  Looking at the code I feel like there's probably some cleaner
> way to do this, but this patch is ok regardless.
> 
> Tom

Hi,

I have pushed this commit.

I cannot close the associated bug on bugzilla[1] because my account does
not have enough privileges (I can only comment on tickets). Could someone
close it for me?

Thanks.
Lancelot.


[1] https://sourceware.org/bugzilla/show_bug.cgi?id=27133