From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id elqYO/B581+NJQAAWB0awg (envelope-from ) for ; Mon, 04 Jan 2021 15:26:24 -0500 Received: by simark.ca (Postfix, from userid 112) id E5B341F0AA; Mon, 4 Jan 2021 15:26:24 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 876771E590 for ; Mon, 4 Jan 2021 15:26:24 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 048C2389247E; Mon, 4 Jan 2021 20:26:24 +0000 (GMT) Received: from gateway31.websitewelcome.com (gateway31.websitewelcome.com [192.185.143.234]) by sourceware.org (Postfix) with ESMTPS id B01F6388C01F for ; Mon, 4 Jan 2021 20:26:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B01F6388C01F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 1C1819F6DE for ; Mon, 4 Jan 2021 14:26:21 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id wWQnknJO7iQiZwWQnkTW7l; Mon, 04 Jan 2021 14:26:21 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9bq1eFcRKnpZ5aIw2AqvthXR882pbgE5a+qJjfn6OF0=; b=Pu/ZFSZtqFBzu4WeKiZmem7vIK kX/3aqnEhAfKL3sCFm0bDq299sUkn3Mx1qa1GIUiw0r82OwGmVhiBavc90yux9RYRDK59OZRg1R+/ T+Zt2SIFAZf6fb3loCzqpVmXf; Received: from 97-122-81-39.hlrn.qwest.net ([97.122.81.39]:51372 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kwWQm-000zue-OQ; Mon, 04 Jan 2021 13:26:20 -0700 From: Tom Tromey To: Lancelot SIX via Gdb-patches Subject: Re: [PATCH][PR gdb/27133] Avoid use after free with logging and debug redirect References: <20210101201127.20835-1-lsix@lancelotsix.com> X-Attribution: Tom Date: Mon, 04 Jan 2021 13:26:20 -0700 In-Reply-To: <20210101201127.20835-1-lsix@lancelotsix.com> (Lancelot SIX via Gdb-patches's message of "Fri, 1 Jan 2021 20:11:28 +0000") Message-ID: <87pn2ke9eb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.81.39 X-Source-L: No X-Exim-ID: 1kwWQm-000zue-OQ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-81-39.hlrn.qwest.net (murgatroyd) [97.122.81.39]:51372 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lancelot SIX Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Lancelot" == Lancelot SIX via Gdb-patches writes: Lancelot> My copyright assignment has not yet been signed by FSF, but the change Lancelot> should be small enough not to require it. Otherwise, it will need to Lancelot> wait a few more days I guess. I don't know the state of this -- could you say? Lancelot> gdb/ChangeLog: Lancelot> PR gdb/27133 Lancelot> * cli/cli-interp.c (cli_interp_base::set_logging): Ensure the Lancelot> unique_ptr is released when the wrapped pointer is kept for later Lancelot> use. Thanks. Looking at the code I feel like there's probably some cleaner way to do this, but this patch is ok regardless. Tom