From: Tom Tromey <tom@tromey.com>
To: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [committed][gdb/testsuite] Disable vgdb tests if xml not supported
Date: Thu, 30 Sep 2021 11:30:33 -0600 [thread overview]
Message-ID: <87pmsq0y4m.fsf@tromey.com> (raw)
In-Reply-To: <20210929135520.GA16103@delia> (Tom de Vries via Gdb-patches's message of "Wed, 29 Sep 2021 15:55:22 +0200")
Tom> +if { [gdb_skip_xml_test] } {
Tom> + # Valgrind gdbserver requires gdb with xml support.
Tom> + return 0
Tom> +}
Do we want/need an 'untested' in there?
I wonder if there's a better way to handle these checks, and also
checking for whether compilation succeeded -- that is, remove the
repeated code blocks in favor of some kind of wrapper that uses "return
-code" (but not an exception) to short-circuit the calling .exp file on
failure. Probably a big task though.
Tom
next prev parent reply other threads:[~2021-09-30 17:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 13:55 Tom de Vries via Gdb-patches
2021-09-30 17:30 ` Tom Tromey [this message]
2021-09-30 21:41 ` Tom de Vries via Gdb-patches
2021-09-30 21:47 ` Tom de Vries via Gdb-patches
2021-10-05 18:15 ` Tom Tromey
2021-10-06 7:40 ` [PATCH][gdb/testsuite] Add proc require in lib/gdb.exp Tom de Vries via Gdb-patches
2021-10-07 11:00 ` [PATCH][gdb/testsuite] Prevent compilation fails with unix/-fPIE/-pie Tom de Vries via Gdb-patches
2021-10-08 14:37 ` Tom de Vries via Gdb-patches
2021-10-11 10:28 ` [PATCH][gdb/testsuite] Add proc require in lib/gdb.exp Tom de Vries via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmsq0y4m.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox