Re: [committed][gdb/testsuite] Disable vgdb tests if xml not supported

[Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>]

On 9/30/21 7:30 PM, Tom Tromey wrote:
> Tom> +if { [gdb_skip_xml_test] } {
> Tom> +    # Valgrind gdbserver requires gdb with xml support.
> Tom> +    return 0
> Tom> +}
> 
> Do we want/need an 'untested' in there?
> 

Ack, will do.

> I wonder if there's a better way to handle these checks, and also
> checking for whether compilation succeeded -- that is, remove the
> repeated code blocks in favor of some kind of wrapper that uses "return
> -code" (but not an exception) to short-circuit the calling .exp file on
> failure.  Probably a big task though.

I suppose we could do in lib/gdb.exp:
...
proc require_xml_support {} {
    if { [gdb_skip_xml_test] } {
        untested "missing xml support"
        return -code return 0
    }
}
...
and then in the test-case we're left with the relatively brief:
...
require_xml_support
...

Or perhaps you mean more generically (which wouldn't require us to write
a proc for each type of require):
...
proc require { fn val } {
    if { [$fn] != $val } {
        untested "$fn != $val"
        return -code return 0
    }
}
...
and:
...
require gdb_skip_xml_test 0
...
?

Thanks,
- Tom