From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QZA6OWz0VWHiXgAAWB0awg (envelope-from ) for ; Thu, 30 Sep 2021 13:31:24 -0400 Received: by simark.ca (Postfix, from userid 112) id D72531EE28; Thu, 30 Sep 2021 13:31:24 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.4 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CE1CB1EDF7 for ; Thu, 30 Sep 2021 13:31:23 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 11D733857C62 for ; Thu, 30 Sep 2021 17:31:23 +0000 (GMT) Received: from gateway36.websitewelcome.com (gateway36.websitewelcome.com [192.185.199.121]) by sourceware.org (Postfix) with ESMTPS id 4FEFC3858C2C for ; Thu, 30 Sep 2021 17:31:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4FEFC3858C2C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 59ED9400EA2FB for ; Thu, 30 Sep 2021 12:30:35 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id VztDmJaf8G0jLVztDmJcSc; Thu, 30 Sep 2021 12:30:35 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ZRJlMK2BHnlZgocdYHPhcDjQ1WfGXtry6Hm7l+8QiUI=; b=AQhClndqhfrxXQCDprgbJ/Cdv8 v5w5dNJjdpjhGtJ7I6+Ko3aFl6vrPSAxB2+mFeOx6U3AGxz0qUD+nO84F9054WsJlBRw7tTpofgZ/ LeHu6VoBEtWF2Afr4iBMrVOxW; Received: from 174-16-0-219.hlrn.qwest.net ([174.16.0.219]:53928 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mVztC-000Tck-Jg; Thu, 30 Sep 2021 11:30:34 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Subject: Re: [committed][gdb/testsuite] Disable vgdb tests if xml not supported References: <20210929135520.GA16103@delia> X-Attribution: Tom Date: Thu, 30 Sep 2021 11:30:33 -0600 In-Reply-To: <20210929135520.GA16103@delia> (Tom de Vries via Gdb-patches's message of "Wed, 29 Sep 2021 15:55:22 +0200") Message-ID: <87pmsq0y4m.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.0.219 X-Source-L: No X-Exim-ID: 1mVztC-000Tck-Jg X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-0-219.hlrn.qwest.net (murgatroyd) [174.16.0.219]:53928 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Tom> +if { [gdb_skip_xml_test] } { Tom> + # Valgrind gdbserver requires gdb with xml support. Tom> + return 0 Tom> +} Do we want/need an 'untested' in there? I wonder if there's a better way to handle these checks, and also checking for whether compilation succeeded -- that is, remove the repeated code blocks in favor of some kind of wrapper that uses "return -code" (but not an exception) to short-circuit the calling .exp file on failure. Probably a big task though. Tom