From: Tom Tromey <tom@tromey.com>
To: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH][gdb/testsuite] Make gdb.base/annota1.exp more robust
Date: Thu, 07 Apr 2022 08:10:22 -0600 [thread overview]
Message-ID: <87pmltc7ch.fsf@tromey.com> (raw)
In-Reply-To: <20220405134732.GA32701@delia> (Tom de Vries via Gdb-patches's message of "Tue, 5 Apr 2022 15:47:33 +0200")
>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
Tom> Fix this by making the matching more robust:
Tom> - rewrite the regexp such that each annotation is on a single line,
Tom> starting with \r\n\032\032 and ending with \r\n
Tom> - add a regexp variable optional_re, that matches all possible optional
Tom> output, and use it as a separator in the first part of the regexp
Tom> Tested on x86_64-linux.
Tom> Any comments?
It seems fine to me.
Thank you.
Tom
next prev parent reply other threads:[~2022-04-07 14:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 13:47 Tom de Vries via Gdb-patches
2022-04-07 14:10 ` Tom Tromey [this message]
2022-04-07 18:38 ` Simon Marchi via Gdb-patches
2022-04-08 9:04 ` Tom de Vries via Gdb-patches
2022-04-11 8:43 ` Tom de Vries via Gdb-patches
2022-04-11 15:21 ` Simon Marchi via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmltc7ch.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox