From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Make gdb.base/annota1.exp more robust
Date: Mon, 11 Apr 2022 11:21:22 -0400 [thread overview]
Message-ID: <50541dee-428e-86b2-0a07-b0873adb6613@polymtl.ca> (raw)
In-Reply-To: <d7d52ca1-3a04-8145-784c-c7e1c68fa692@suse.de>
> Pushed, but now that I reply here I see I didn't fully read the rationale for the patch you posted, and didn't follow up on that, apologies for that.
>
> So, perhaps you're right, perhaps we don't care about the order (though it would be nice for me to understand why we don't care).
>
> I understood the matching in the test-case to be very loose due to having to juggle mostly the variance in non-annotation output. So I decided to "fix" this by being as strict as possible in matching annotations, and as simple as possible in matching non-annotations.
>
> I hope the committed patch will be sufficient though.
>
> I you think there's still an issue, then I can revert and apply your patch.
I'm happy with your explanation and your patch. It seems to fix the
issue I observed, it's possible that I did not analyze the problem
correctly. Thanks!
Simon
prev parent reply other threads:[~2022-04-11 15:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 13:47 Tom de Vries via Gdb-patches
2022-04-07 14:10 ` Tom Tromey
2022-04-07 18:38 ` Simon Marchi via Gdb-patches
2022-04-08 9:04 ` Tom de Vries via Gdb-patches
2022-04-11 8:43 ` Tom de Vries via Gdb-patches
2022-04-11 15:21 ` Simon Marchi via Gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50541dee-428e-86b2-0a07-b0873adb6613@polymtl.ca \
--to=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox