Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@redhat.com>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/testsuite] Handle missing curses in gdb.python/py-missing-debug.exp
Date: Mon, 09 Sep 2024 17:57:08 +0100	[thread overview]
Message-ID: <87plpcrcij.fsf@redhat.com> (raw)
In-Reply-To: <87zfogrjtm.fsf@redhat.com>

Andrew Burgess <aburgess@redhat.com> writes:

> Tom de Vries <tdevries@suse.de> writes:
>
>> On 9/8/24 22:38, Andrew Burgess wrote:
>>> Tom de Vries <tdevries@suse.de> writes:
>>> 
>>>> On a system with python 3.6, module gdb.missing_debug imports module curses,
>>>> so when running test-case gdb.python/py-missing-debug.exp on a system without
>>>> that module installed, we run into:
>>>> ...
>>>> (gdb) source py-missing-debug.py^M
>>>> Python Exception <class 'ImportError'>: Module 'curses' is not installed.^M
>>>> Use:^M
>>>>    sudo zypper install python36-curses^M
>>>> to install it.^M
>>>> Error occurred in Python: Module 'curses' is not installed.^M
>>>> Use:^M
>>>>    sudo zypper install python36-curses^M
>>>> to install it.^M
>>>> (gdb) FAIL: gdb.python/py-missing-debug.exp: source python script
>>> 
>>
>> Hi Andrew,
>>
>>> Do you know where the curses include is coming from?
>>> 
>>
>> Yes, from gdb/python/lib/gdb/missing_debug.py:
>> ...
>> if sys.version_info >= (3, 7):
>>      # Functions str.isascii() and str.isalnum are available starting Python
>>      # 3.7.
>>      def isascii(ch):
>>          return ch.isascii()
>>
>>      def isalnum(ch):
>>          return ch.isalnum()
>>
>> else:
>>      # Fall back to curses.ascii.isascii() and curses.ascii.isalnum() for
>>      # earlier versions.
>>      from curses.ascii import isalnum, isascii
>> ...
>
> Thanks for explaining this.  I wonder if there's a way we could avoid
> that dependency... I'll have a think about that one.

I posted:

https://inbox.sourceware.org/gdb-patches/7c515b37e2bf7ca319e76ebcbd3b16137d8919c3.1725900938.git.aburgess@redhat.com/T/#u

Thanks,
Andrew


      reply	other threads:[~2024-09-09 16:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-07  3:37 Tom de Vries
2024-09-07 18:09 ` Kevin Buettner
2024-09-08 20:38 ` Andrew Burgess
2024-09-09  2:33   ` Tom de Vries
2024-09-09 14:19     ` Andrew Burgess
2024-09-09 16:57       ` Andrew Burgess [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87plpcrcij.fsf@redhat.com \
    --to=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox