Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PATCH] [gdb/testsuite] Handle missing curses in gdb.python/py-missing-debug.exp
Date: Sat,  7 Sep 2024 05:37:13 +0200	[thread overview]
Message-ID: <20240907033713.4483-1-tdevries@suse.de> (raw)

On a system with python 3.6, module gdb.missing_debug imports module curses,
so when running test-case gdb.python/py-missing-debug.exp on a system without
that module installed, we run into:
...
(gdb) source py-missing-debug.py^M
Python Exception <class 'ImportError'>: Module 'curses' is not installed.^M
Use:^M
  sudo zypper install python36-curses^M
to install it.^M
Error occurred in Python: Module 'curses' is not installed.^M
Use:^M
  sudo zypper install python36-curses^M
to install it.^M
(gdb) FAIL: gdb.python/py-missing-debug.exp: source python script
...

Fix this by issuing UNSUPPORTED instead, and bailing out.

Tested on x86_64-linux.

PR testsuite/31576
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31576
---
 gdb/testsuite/gdb.python/py-missing-debug.exp | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/gdb.python/py-missing-debug.exp b/gdb/testsuite/gdb.python/py-missing-debug.exp
index dfc0a467b2a..9d853d3a311 100644
--- a/gdb/testsuite/gdb.python/py-missing-debug.exp
+++ b/gdb/testsuite/gdb.python/py-missing-debug.exp
@@ -58,8 +58,21 @@ with_test_prefix "initial checks" {
 }
 
 # Load the Python script into GDB.
-gdb_test "source $remote_python_file" "^Success" \
-    "source python script"
+set python_script_loaded 0
+set re_no_curses [string_to_regexp "Module 'curses' is not installed."]
+gdb_test_multiple "source $remote_python_file" "source python script" {
+    -re -wrap $re_no_curses.* {
+	unsupported $gdb_test_name
+    }
+    -re -wrap "^Success" {
+	set python_script_loaded 1
+	pass $gdb_test_name
+    }
+}
+
+if { ! $python_script_loaded } {
+    return
+}
 
 # Setup the separate debug info directory.  This isn't actually needed until
 # some of the later tests, but might as well get this done now.

base-commit: 4723415cda09b09dbac743f30f877355a49fdee2
-- 
2.35.3


             reply	other threads:[~2024-09-07  3:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-07  3:37 Tom de Vries [this message]
2024-09-07 18:09 ` Kevin Buettner
2024-09-08 20:38 ` Andrew Burgess
2024-09-09  2:33   ` Tom de Vries
2024-09-09 14:19     ` Andrew Burgess
2024-09-09 16:57       ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240907033713.4483-1-tdevries@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox