From: Kevin Buettner <kevinb@redhat.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/testsuite] Handle missing curses in gdb.python/py-missing-debug.exp
Date: Sat, 7 Sep 2024 11:09:07 -0700 [thread overview]
Message-ID: <20240907110907.407df0ce@f40-zbm-amd> (raw)
In-Reply-To: <20240907033713.4483-1-tdevries@suse.de>
On Sat, 7 Sep 2024 05:37:13 +0200
Tom de Vries <tdevries@suse.de> wrote:
> On a system with python 3.6, module gdb.missing_debug imports module curses,
> so when running test-case gdb.python/py-missing-debug.exp on a system without
> that module installed, we run into:
> ...
> (gdb) source py-missing-debug.py^M
> Python Exception <class 'ImportError'>: Module 'curses' is not installed.^M
> Use:^M
> sudo zypper install python36-curses^M
> to install it.^M
> Error occurred in Python: Module 'curses' is not installed.^M
> Use:^M
> sudo zypper install python36-curses^M
> to install it.^M
> (gdb) FAIL: gdb.python/py-missing-debug.exp: source python script
> ...
>
> Fix this by issuing UNSUPPORTED instead, and bailing out.
>
> Tested on x86_64-linux.
>
> PR testsuite/31576
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31576
LGTM.
Approved-by: Kevin Buettner <kevinb@redhat.com>
next prev parent reply other threads:[~2024-09-07 18:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-07 3:37 Tom de Vries
2024-09-07 18:09 ` Kevin Buettner [this message]
2024-09-08 20:38 ` Andrew Burgess
2024-09-09 2:33 ` Tom de Vries
2024-09-09 14:19 ` Andrew Burgess
2024-09-09 16:57 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240907110907.407df0ce@f40-zbm-amd \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox