Re: [PATCH] [gdb] Use using instead of typedef

[Tom Tromey <tom@tromey.com>]

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> After commit 1eed06ae51d ("[gdbsupport] Use using instead of typedef in
Tom> next_iterator") I wondered if I could do something similar using sed.

First of all, thanks for doing this.

I don't know how anyone else feels but I normally find 'using' simpler
to understand, I suppose because I don't need to try to decode the right
hand side to find the name being defined -- it's right there before the
'='.

So, I am in favor of this patch.  I'm going to approve it but I think
you should wait for a bit before checking it in, in case someone wants
to object.

Approved-By: Tom Tromey <tom@tromey.com>


Also -- and it should not block this patch at all -- there are some
cases that this missed.  There are some typedefs spanning multiple
lines, e.g., from expop.h:

typedef struct value *binary_ftype (struct type *expect_type,
				    struct expression *exp,
				    enum noside noside, enum exp_opcode op,
				    struct value *arg1, struct value *arg2);

thanks,
Tom