Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb] Use using instead of typedef
Date: Tue, 9 Jun 2026 18:37:39 -0400	[thread overview]
Message-ID: <46b1c0f1-8e1d-4154-95b4-effb0eea64ef@simark.ca> (raw)
In-Reply-To: <87pl1zfymw.fsf@tromey.com>



On 2026-06-09 12:48, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom> After commit 1eed06ae51d ("[gdbsupport] Use using instead of typedef in
> Tom> next_iterator") I wondered if I could do something similar using sed.
> 
> First of all, thanks for doing this.
> 
> I don't know how anyone else feels but I normally find 'using' simpler
> to understand, I suppose because I don't need to try to decode the right
> hand side to find the name being defined -- it's right there before the
> '='.
> 
> So, I am in favor of this patch.  I'm going to approve it but I think
> you should wait for a bit before checking it in, in case someone wants
> to object.

I am also in favor, I think it's easier to read, and I guess it's the
"correct" thing to use in modern C++.

Simon

  reply	other threads:[~2026-06-09 22:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-09 16:22 Tom de Vries
2026-06-09 16:48 ` Tom Tromey
2026-06-09 22:37   ` Simon Marchi [this message]
2026-06-10 15:50   ` Andrew Burgess
2026-06-11  6:57     ` Tom de Vries
2026-06-12 11:00       ` Lancelot SIX
2026-06-12 11:01         ` Tom de Vries
2026-06-12 11:12           ` Lancelot SIX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46b1c0f1-8e1d-4154-95b4-effb0eea64ef@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox