From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QcnpDApEKGoVEj4AWB0awg (envelope-from ) for ; Tue, 09 Jun 2026 12:49:14 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=QlWRWKzB; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 30D031E070; Tue, 09 Jun 2026 12:49:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3D7541E070 for ; Tue, 09 Jun 2026 12:49:13 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 23C3D4C31877 for ; Tue, 9 Jun 2026 16:49:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 23C3D4C31877 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=QlWRWKzB Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 5C74B4BA2E10 for ; Tue, 9 Jun 2026 16:48:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5C74B4BA2E10 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5C74B4BA2E10 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781023725; cv=none; b=Uf6/cYmv11ZiT+fi2F5mcsDSi8SDMdXuNr/1c4UlrTGvOZER/vvZoKRl0JNt4z4YotLKhflnTOdO75Ln01mO1d9EP3gWu2km/7g5ukVw6M5Sq24ZjKxcGuJyvdSElDPV6QV+stIIcTRO+fxrc9HRZ75lb0nZNZxJ90LhaFL9JNA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781023725; c=relaxed/simple; bh=mCIgLqg1SA58vbLjQY1Y7EGtX9THcd4fPI3ZXZci2Lo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=LrMEmUSC+xK32cgnW18vcNVoK7+SxBiVGs06vD1RJ2y/ZonF/qAeAYZ3lIerNZF4+zRv9H6no6+EbDPGwJpYrlWURR7V/zAGTO68SmNuaqi+LXTYE7tCwW2vlCqteVMIKGoA2UiBKYjXyjzWNIV8S9W7Q4lM3lom6Z9ZRT5E5Q4= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=QlWRWKzB reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5C74B4BA2E10 Received: from eig-obgw-5004b.ext.cloudfilter.net ([10.0.29.208]) by cmsmtp with ESMTPS id WwV7wr1UMMFEgWzd5wTokB; Tue, 09 Jun 2026 16:48:43 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Wzd3w4N1RnfJUWzd3wbFEm; Tue, 09 Jun 2026 16:48:41 +0000 X-Authority-Analysis: v=2.4 cv=KajSsRYD c=1 sm=1 tr=0 ts=6a2843eb a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=FelO9ux0wxsA:10 a=ItBw4LHWJt0A:10 a=zstS-IiYAAAA:8 a=7giu40Kr2V95IS7YDAgA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=46RB8xd7QTWaMEqhYJsaS8uNo65JdVpsOH1gfs/KkVQ=; b=QlWRWKzBPya5LVfoHVH//hIEso ydsI1EFLp38DkEn1221/xdwjB3WZ3ZFM0tjX9Nxet56Qh2Wn0IvAtSQXpyMgKBGxlNFFlVin9t2Eq v3k8+1imfPty6XJDBXke7x9JY; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:34520 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.2) (envelope-from ) id 1wWzd2-00000003mzb-3yu5; Tue, 09 Jun 2026 10:48:41 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb] Use using instead of typedef In-Reply-To: <20260609162257.1674992-1-tdevries@suse.de> (Tom de Vries's message of "Tue, 9 Jun 2026 18:22:57 +0200") References: <20260609162257.1674992-1-tdevries@suse.de> X-Attribution: Tom Date: Tue, 09 Jun 2026 10:48:39 -0600 Message-ID: <87pl1zfymw.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wWzd2-00000003mzb-3yu5 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:34520 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfB0BDKsEJ73EXdpALrEHJp12ggYuF9hDmGIU1t2dVvbpFLo6FmWwjFn9a/FZzV55KzwWDfrP7ayXVnv8/wxkMxQHkgwWCwwJe4CGBkqH1Kpy1toiD0sT uzkGFutByll+36doa6wLTIiAyM39Ch3h0vJR9StGg5t+LwyPtvObvIijIGfFSmUxZZjMfEFFD8kFJXBZyF43w5nCRssyIvGMMx4= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom de Vries writes: Tom> After commit 1eed06ae51d ("[gdbsupport] Use using instead of typedef in Tom> next_iterator") I wondered if I could do something similar using sed. First of all, thanks for doing this. I don't know how anyone else feels but I normally find 'using' simpler to understand, I suppose because I don't need to try to decode the right hand side to find the name being defined -- it's right there before the '='. So, I am in favor of this patch. I'm going to approve it but I think you should wait for a bit before checking it in, in case someone wants to object. Approved-By: Tom Tromey Also -- and it should not block this patch at all -- there are some cases that this missed. There are some typedefs spanning multiple lines, e.g., from expop.h: typedef struct value *binary_ftype (struct type *expect_type, struct expression *exp, enum noside noside, enum exp_opcode op, struct value *arg1, struct value *arg2); thanks, Tom