From: Tom Tromey <tromey@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: Pedro Alves <palves@redhat.com>,
"gdb-patches\@sourceware.org ml"
<gdb-patches@sourceware.org>
Subject: Re: [RFA] "constify" parse_exp_1
Date: Fri, 08 Mar 2013 14:54:00 -0000 [thread overview]
Message-ID: <87obeuc58e.fsf@fleche.redhat.com> (raw)
In-Reply-To: <51393886.9030602@redhat.com> (Keith Seitz's message of "Thu, 07 Mar 2013 17:01:58 -0800")
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Pedro> Your patch seems to make sym_name unused, even. There may be
Pedro> more instances of this in the patch. /me off to bed. :-)
Keith> I *think* that's the only one.
There is a deletable strdup in gdbpy_parse_and_eval.
I don't know if there are others in the tree.
I think you need to look at the indirect callers of parse_exp_1.
Tom
next prev parent reply other threads:[~2013-03-08 14:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-08 0:12 Keith Seitz
2013-03-08 0:22 ` Pedro Alves
2013-03-08 1:02 ` Keith Seitz
2013-03-08 12:27 ` Pedro Alves
2013-03-08 13:55 ` Pedro Alves
2013-03-09 1:00 ` Pedro Alves
2013-03-09 1:04 ` Keith Seitz
2013-03-11 22:09 ` Keith Seitz
2013-03-12 10:18 ` Pedro Alves
2013-03-12 17:40 ` Keith Seitz
2013-03-08 14:54 ` Tom Tromey [this message]
2013-03-11 16:50 ` Keith Seitz
2013-03-11 18:30 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obeuc58e.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox