From: Keith Seitz <keiths@redhat.com>
To: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [RFA] "constify" parse_exp_1
Date: Tue, 12 Mar 2013 17:40:00 -0000 [thread overview]
Message-ID: <513F6867.2020203@redhat.com> (raw)
In-Reply-To: <513F00EF.5040001@redhat.com>
On 03/12/2013 03:18 AM, Pedro Alves wrote:
> s/craete/create
Fixed.
> (Minor note: pedantically, uppercase is used when talking
> about the value of the variable, rather than the variable
> itself.)
Fixed/changed.
>> -extern char *skip_to_space (char *inp);
>> +#define skip_to_space(INP) ((char *) skip_to_space_const ((INP)))
>
> Double (())s not necessary:
Fixed.
>
> #define skip_to_space(INP) ((char *) skip_to_space_const (INP))
>
> Can you please add:
>
> + /* A const-correct version of the above. */
>
Fixed.
> Otherwise this all looks good to me.
>
Committed. Thank you for taking a look at this.
Keith
next prev parent reply other threads:[~2013-03-12 17:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-08 0:12 Keith Seitz
2013-03-08 0:22 ` Pedro Alves
2013-03-08 1:02 ` Keith Seitz
2013-03-08 12:27 ` Pedro Alves
2013-03-08 13:55 ` Pedro Alves
2013-03-09 1:00 ` Pedro Alves
2013-03-09 1:04 ` Keith Seitz
2013-03-11 22:09 ` Keith Seitz
2013-03-12 10:18 ` Pedro Alves
2013-03-12 17:40 ` Keith Seitz [this message]
2013-03-08 14:54 ` Tom Tromey
2013-03-11 16:50 ` Keith Seitz
2013-03-11 18:30 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513F6867.2020203@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox