From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2301 invoked by alias); 12 Mar 2013 17:40:06 -0000 Received: (qmail 2061 invoked by uid 22791); 12 Mar 2013 17:40:04 -0000 X-SWARE-Spam-Status: No, hits=-8.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Mar 2013 17:39:53 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2CHdq7A011644 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 12 Mar 2013 13:39:52 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r2CHdpOf030130 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Tue, 12 Mar 2013 13:39:52 -0400 Message-ID: <513F6867.2020203@redhat.com> Date: Tue, 12 Mar 2013 17:40:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: GDB Patches Subject: Re: [RFA] "constify" parse_exp_1 References: <51392C56.7040302@redhat.com> <51392F3F.5090102@redhat.com> <51393886.9030602@redhat.com> <5139D92B.5090106@redhat.com> <5139EDDB.8080201@redhat.com> <513A899C.2030800@redhat.com> <513A8A80.4040905@redhat.com> <513E5612.9020607@redhat.com> <513F00EF.5040001@redhat.com> In-Reply-To: <513F00EF.5040001@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00531.txt.bz2 On 03/12/2013 03:18 AM, Pedro Alves wrote: > s/craete/create Fixed. > (Minor note: pedantically, uppercase is used when talking > about the value of the variable, rather than the variable > itself.) Fixed/changed. >> -extern char *skip_to_space (char *inp); >> +#define skip_to_space(INP) ((char *) skip_to_space_const ((INP))) > > Double (())s not necessary: Fixed. > > #define skip_to_space(INP) ((char *) skip_to_space_const (INP)) > > Can you please add: > > + /* A const-correct version of the above. */ > Fixed. > Otherwise this all looks good to me. > Committed. Thank you for taking a look at this. Keith