From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1774 invoked by alias); 8 Mar 2013 14:54:08 -0000 Received: (qmail 1760 invoked by uid 22791); 8 Mar 2013 14:54:05 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 08 Mar 2013 14:53:55 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r28Ert6P030826 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 8 Mar 2013 09:53:55 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r28Err7l019523 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 8 Mar 2013 09:53:54 -0500 From: Tom Tromey To: Keith Seitz Cc: Pedro Alves , "gdb-patches\@sourceware.org ml" Subject: Re: [RFA] "constify" parse_exp_1 References: <51392C56.7040302@redhat.com> <51392F3F.5090102@redhat.com> <51393886.9030602@redhat.com> Date: Fri, 08 Mar 2013 14:54:00 -0000 In-Reply-To: <51393886.9030602@redhat.com> (Keith Seitz's message of "Thu, 07 Mar 2013 17:01:58 -0800") Message-ID: <87obeuc58e.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00373.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Pedro> Your patch seems to make sym_name unused, even. There may be Pedro> more instances of this in the patch. /me off to bed. :-) Keith> I *think* that's the only one. There is a deletable strdup in gdbpy_parse_and_eval. I don't know if there are others in the tree. I think you need to look at the indirect callers of parse_exp_1. Tom