Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Doug Evans <dje@google.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
	gdb-patches <gdb-patches@sourceware.org>,
	       palves@redhat.com
Subject: Re: [RFA, doc RFA] set print frame-arguments-raw on|off
Date: Wed, 17 Jul 2013 19:50:00 -0000	[thread overview]
Message-ID: <87oba1dl06.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20966.61429.746380.387990@ruffy.mtv.corp.google.com> (Doug	Evans's message of "Wed, 17 Jul 2013 12:26:45 -0700")

>>>>> "Doug" == Doug Evans <dje@google.com> writes:

Doug> Here is a revised version of "set print frame-arguments-raw".
Doug> It renames the option to "set print raw frame-arguments" to allow for
Doug> other things that we might want to control raw printing of.

Looks good to me.

It might be nice to allow this as an argument to "bt" as well, for
one-off uses.

Doug> There's one thing I'm not sure of:
Doug> which one of gdbcmd.h vs cli/cli-cmds.h to use?
Doug> They each declare the set/show list globals.
Doug> gdbcmd.h has a comment saying it's deprecated.
Doug> However, it defines maintenance_{set,show}_cmdlist whereas cli-cmds.h
Doug> does not (which I agree with to the extent that if I were to try to clean
Doug> this area up I would make a few changes, e.g., better separation of gdb
Doug> and cli-as-module, but they're beyond the scope of this patch).

I think cli/cli-cmds.h is preferable for "pure CLI" things.
IMNSHO any public object ought to have a single declaration in a single
header file.  Any kind of duplication here is bad.

Tom


  parent reply	other threads:[~2013-07-17 19:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-30  0:37 Doug Evans
2013-06-30 14:58 ` Doug Evans
2013-06-30 15:17   ` Eli Zaretskii
2013-06-30 18:11     ` Doug Evans
2013-07-17 19:26       ` Doug Evans
2013-07-17 19:34         ` Eli Zaretskii
2013-07-17 19:50         ` Tom Tromey [this message]
2013-07-17 19:54           ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oba1dl06.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=dje@google.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox