From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23234 invoked by alias); 17 Jul 2013 19:50:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23225 invoked by uid 89); 17 Jul 2013 19:50:24 -0000 X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 17 Jul 2013 19:50:24 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6HJo6Ci006600 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 17 Jul 2013 15:50:14 -0400 Received: from barimba (ovpn-113-128.phx2.redhat.com [10.3.113.128]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r6HJo15o024125 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 17 Jul 2013 15:50:04 -0400 From: Tom Tromey To: Doug Evans Cc: Eli Zaretskii , gdb-patches , palves@redhat.com Subject: Re: [RFA, doc RFA] set print frame-arguments-raw on|off References: <20943.41509.270378.842286@ruffy.mtv.corp.google.com> <83ip0vd4sf.fsf@gnu.org> <20966.61429.746380.387990@ruffy.mtv.corp.google.com> Date: Wed, 17 Jul 2013 19:50:00 -0000 In-Reply-To: <20966.61429.746380.387990@ruffy.mtv.corp.google.com> (Doug Evans's message of "Wed, 17 Jul 2013 12:26:45 -0700") Message-ID: <87oba1dl06.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-07/txt/msg00427.txt.bz2 >>>>> "Doug" == Doug Evans writes: Doug> Here is a revised version of "set print frame-arguments-raw". Doug> It renames the option to "set print raw frame-arguments" to allow for Doug> other things that we might want to control raw printing of. Looks good to me. It might be nice to allow this as an argument to "bt" as well, for one-off uses. Doug> There's one thing I'm not sure of: Doug> which one of gdbcmd.h vs cli/cli-cmds.h to use? Doug> They each declare the set/show list globals. Doug> gdbcmd.h has a comment saying it's deprecated. Doug> However, it defines maintenance_{set,show}_cmdlist whereas cli-cmds.h Doug> does not (which I agree with to the extent that if I were to try to clean Doug> this area up I would make a few changes, e.g., better separation of gdb Doug> and cli-as-module, but they're beyond the scope of this patch). I think cli/cli-cmds.h is preferable for "pure CLI" things. IMNSHO any public object ought to have a single declaration in a single header file. Any kind of duplication here is bad. Tom