Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA, doc RFA] set print frame-arguments-raw on|off
Date: Sun, 30 Jun 2013 15:17:00 -0000	[thread overview]
Message-ID: <83ip0vd4sf.fsf@gnu.org> (raw)
In-Reply-To: <20943.41509.270378.842286@ruffy.mtv.corp.google.com>

> From: Doug Evans <dje@google.com>
> Date: Sat, 29 Jun 2013 20:12:37 -0700
> 
>  > Sometimes it's nice to print stack frame arguments in raw form.
>  > [And not just as one-offs, but as the default.]
>  > 
>  > I thought of extending "set print frame-arguments" into something like
>  > none, raw-scalars, raw-all, scalars, all.
>  > But I like this better: raw-vs-pretty is orthogonal to scalars-vs-all.
>  > E.g., If we later extend "print frame-arguments" it'll be easier if raw-ness
>  > is a separate parameter.

Thanks.

> diff -u -p -r1.605 NEWS
> --- NEWS	26 Jun 2013 08:17:26 -0000	1.605
> +++ NEWS	30 Jun 2013 03:02:56 -0000
> @@ -34,6 +34,11 @@ maint set|show per-command symtab
>  
>  * New options
>  
> +set print frame-arguments-raw
> +show print frame-arguments-raw
> +  Set/show whether to print frame arguments in raw mode,
> +  not pretty-printed.
> +

This part is OK, although I'd suggest to say something more explicit,
like "... disregarding any defined pretty-printers."

> --- doc/gdb.texinfo	26 Jun 2013 08:17:26 -0000	1.1099
> +++ doc/gdb.texinfo	29 Jun 2013 22:11:03 -0000
> @@ -9030,6 +9030,17 @@ thus speeding up the display of each Ada
>  @item show print frame-arguments
>  Show how the value of arguments should be displayed when printing a frame.
>  
> +@item set print frame-arguments-raw on
> +Print frame arguments in raw, non pretty-printed, form.
> +
> +@item set print frame-arguments-raw off
> +Print frame arguments in pretty-printed form, if there is a pretty-printer
> +for the value (@pxref{Pretty Printing}).
> +Otherwise print the value in raw form.
> +
> +@item show print frame-arguments-raw
> +Show whether to print frame arguments in raw form.

This is fine, but please state the default value of the option.

OK with those changes.


  reply	other threads:[~2013-06-30 14:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-30  0:37 Doug Evans
2013-06-30 14:58 ` Doug Evans
2013-06-30 15:17   ` Eli Zaretskii [this message]
2013-06-30 18:11     ` Doug Evans
2013-07-17 19:26       ` Doug Evans
2013-07-17 19:34         ` Eli Zaretskii
2013-07-17 19:50         ` Tom Tromey
2013-07-17 19:54           ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ip0vd4sf.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox