From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2517 invoked by alias); 30 Jun 2013 14:58:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2506 invoked by uid 89); 30 Jun 2013 14:58:37 -0000 X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL autolearn=no version=3.3.1 Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sun, 30 Jun 2013 14:58:36 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MP700300O7UOM00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Sun, 30 Jun 2013 17:58:05 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MP7003JTO8THI30@a-mtaout20.012.net.il>; Sun, 30 Jun 2013 17:58:05 +0300 (IDT) Date: Sun, 30 Jun 2013 15:17:00 -0000 From: Eli Zaretskii Subject: Re: [RFA, doc RFA] set print frame-arguments-raw on|off In-reply-to: <20943.41509.270378.842286@ruffy.mtv.corp.google.com> To: Doug Evans Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83ip0vd4sf.fsf@gnu.org> References: <20943.41509.270378.842286@ruffy.mtv.corp.google.com> X-SW-Source: 2013-06/txt/msg00939.txt.bz2 > From: Doug Evans > Date: Sat, 29 Jun 2013 20:12:37 -0700 > > > Sometimes it's nice to print stack frame arguments in raw form. > > [And not just as one-offs, but as the default.] > > > > I thought of extending "set print frame-arguments" into something like > > none, raw-scalars, raw-all, scalars, all. > > But I like this better: raw-vs-pretty is orthogonal to scalars-vs-all. > > E.g., If we later extend "print frame-arguments" it'll be easier if raw-ness > > is a separate parameter. Thanks. > diff -u -p -r1.605 NEWS > --- NEWS 26 Jun 2013 08:17:26 -0000 1.605 > +++ NEWS 30 Jun 2013 03:02:56 -0000 > @@ -34,6 +34,11 @@ maint set|show per-command symtab > > * New options > > +set print frame-arguments-raw > +show print frame-arguments-raw > + Set/show whether to print frame arguments in raw mode, > + not pretty-printed. > + This part is OK, although I'd suggest to say something more explicit, like "... disregarding any defined pretty-printers." > --- doc/gdb.texinfo 26 Jun 2013 08:17:26 -0000 1.1099 > +++ doc/gdb.texinfo 29 Jun 2013 22:11:03 -0000 > @@ -9030,6 +9030,17 @@ thus speeding up the display of each Ada > @item show print frame-arguments > Show how the value of arguments should be displayed when printing a frame. > > +@item set print frame-arguments-raw on > +Print frame arguments in raw, non pretty-printed, form. > + > +@item set print frame-arguments-raw off > +Print frame arguments in pretty-printed form, if there is a pretty-printer > +for the value (@pxref{Pretty Printing}). > +Otherwise print the value in raw form. > + > +@item show print frame-arguments-raw > +Show whether to print frame arguments in raw form. This is fine, but please state the default value of the option. OK with those changes.