From: Tom Tromey <tromey@redhat.com>
To: ali_anwar <ali_anwar@codesourcery.com>
Cc: Keith Seitz <keiths@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix for PR15117
Date: Wed, 07 Aug 2013 20:01:00 -0000 [thread overview]
Message-ID: <87ob995kzd.fsf@fleche.redhat.com> (raw)
In-Reply-To: <5201DE39.6060302@codesourcery.com> (ali anwar's message of "Wed, 7 Aug 2013 10:42:17 +0500")
>>>>> "Ali" == ali anwar <ali_anwar@codesourcery.com> writes:
Ali> Thank you for reviewing the patch again.
It's customary to always send the ChangeLog entry when re-sending a
patch.
I personally do this by putting the ChangeLog entry into the git commit
and using git send-email, but there are many ways to manage it.
The patch is ok with the ChangeLog from up-thread.
FWIW I am not especially fond of convenience variables in linespecs.
They seem odd to me. Like, won't the breakpoint move at re-set if the
variable changes? Also I note that they aren't documented... But your
patch is just fixing an error in the existing support, which I think
makes it ok to go in.
thanks,
Tom
next prev parent reply other threads:[~2013-08-07 20:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 16:55 ali_anwar
2013-07-30 18:56 ` Keith Seitz
2013-08-02 12:14 ` ali_anwar
2013-08-02 17:49 ` Keith Seitz
2013-08-06 19:51 ` ali_anwar
2013-08-07 5:42 ` ali_anwar
2013-08-07 20:01 ` Tom Tromey [this message]
2013-08-08 14:56 ` Pedro Alves
2013-08-08 20:05 ` Tom Tromey
2013-08-12 12:12 ` ali_anwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ob995kzd.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=ali_anwar@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox