Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: ali_anwar <ali_anwar@codesourcery.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Keith Seitz <keiths@redhat.com>, <gdb-patches@sourceware.org>,
	Pedro Alves	<palves@redhat.com>
Subject: Re: [PATCH] Fix for PR15117
Date: Mon, 12 Aug 2013 12:12:00 -0000	[thread overview]
Message-ID: <5208D0F7.4060706@codesourcery.com> (raw)
In-Reply-To: <87ob995kzd.fsf@fleche.redhat.com>

On 08/08/2013 01:01 AM, Tom Tromey wrote:
>>>>>> "Ali" == ali anwar <ali_anwar@codesourcery.com> writes:
>
> Ali> Thank you for reviewing the patch again.
>
> It's customary to always send the ChangeLog entry when re-sending a
> patch.
>
> I personally do this by putting the ChangeLog entry into the git commit
> and using git send-email, but there are many ways to manage it.
>
> The patch is ok with the ChangeLog from up-thread.
>

Committed, but while committing I passed an incorrect file as a commit 
message, is there a way or a need to change the commit message?

I guess only the person with admin rights could do that. Following are 
the contents of commit message I intended to pass while committing.


PR breakpoints/15117
* linespec.c (linespec_parse_basic): Check for convenience
variable or history value while parsing.
* testsuite/gdb.base/break.exp: Test break via convenience
variable with file name.

I apologize for the inconvenience.

Regards,
-Ali


      parent reply	other threads:[~2013-08-12 12:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-30 16:55 ali_anwar
2013-07-30 18:56 ` Keith Seitz
2013-08-02 12:14   ` ali_anwar
2013-08-02 17:49     ` Keith Seitz
2013-08-06 19:51       ` ali_anwar
2013-08-07  5:42       ` ali_anwar
2013-08-07 20:01         ` Tom Tromey
2013-08-08 14:56           ` Pedro Alves
2013-08-08 20:05             ` Tom Tromey
2013-08-12 12:12           ` ali_anwar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5208D0F7.4060706@codesourcery.com \
    --to=ali_anwar@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    --cc=palves@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox