From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15975 invoked by alias); 12 Aug 2013 12:12:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15963 invoked by uid 89); 12 Aug 2013 12:12:21 -0000 X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.2 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 12 Aug 2013 12:12:05 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1V8qyh-00034z-V7 from Ali_Anwar@mentor.com ; Mon, 12 Aug 2013 05:12:03 -0700 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 12 Aug 2013 05:12:03 -0700 Received: from [137.202.157.39] (147.34.91.1) by mail-na.mentorg.com (147.34.97.43) with Microsoft SMTP Server (TLS) id 14.2.247.3; Mon, 12 Aug 2013 05:12:02 -0700 Message-ID: <5208D0F7.4060706@codesourcery.com> Date: Mon, 12 Aug 2013 12:12:00 -0000 From: ali_anwar User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: Keith Seitz , , Pedro Alves Subject: Re: [PATCH] Fix for PR15117 References: <51F7EFF1.6030609@codesourcery.com> <51F80C61.9080308@redhat.com> <51FBA2A6.8000307@codesourcery.com> <51FBF127.7000108@redhat.com> <5201DE39.6060302@codesourcery.com> <87ob995kzd.fsf@fleche.redhat.com> In-Reply-To: <87ob995kzd.fsf@fleche.redhat.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00299.txt.bz2 On 08/08/2013 01:01 AM, Tom Tromey wrote: >>>>>> "Ali" == ali anwar writes: > > Ali> Thank you for reviewing the patch again. > > It's customary to always send the ChangeLog entry when re-sending a > patch. > > I personally do this by putting the ChangeLog entry into the git commit > and using git send-email, but there are many ways to manage it. > > The patch is ok with the ChangeLog from up-thread. > Committed, but while committing I passed an incorrect file as a commit message, is there a way or a need to change the commit message? I guess only the person with admin rights could do that. Following are the contents of commit message I intended to pass while committing. PR breakpoints/15117 * linespec.c (linespec_parse_basic): Check for convenience variable or history value while parsing. * testsuite/gdb.base/break.exp: Test break via convenience variable with file name. I apologize for the inconvenience. Regards, -Ali