From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30011 invoked by alias); 7 Aug 2013 20:01:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30001 invoked by uid 89); 7 Aug 2013 20:01:21 -0000 X-Spam-SWARE-Status: No, score=-5.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 07 Aug 2013 20:01:21 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r77K1Cfe003259 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 7 Aug 2013 16:01:12 -0400 Received: from barimba (ovpn-113-128.phx2.redhat.com [10.3.113.128]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r77K1An2020066 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 7 Aug 2013 16:01:11 -0400 From: Tom Tromey To: ali_anwar Cc: Keith Seitz , Subject: Re: [PATCH] Fix for PR15117 References: <51F7EFF1.6030609@codesourcery.com> <51F80C61.9080308@redhat.com> <51FBA2A6.8000307@codesourcery.com> <51FBF127.7000108@redhat.com> <5201DE39.6060302@codesourcery.com> Date: Wed, 07 Aug 2013 20:01:00 -0000 In-Reply-To: <5201DE39.6060302@codesourcery.com> (ali anwar's message of "Wed, 7 Aug 2013 10:42:17 +0500") Message-ID: <87ob995kzd.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-08/txt/msg00214.txt.bz2 >>>>> "Ali" == ali anwar writes: Ali> Thank you for reviewing the patch again. It's customary to always send the ChangeLog entry when re-sending a patch. I personally do this by putting the ChangeLog entry into the git commit and using git send-email, but there are many ways to manage it. The patch is ok with the ChangeLog from up-thread. FWIW I am not especially fond of convenience variables in linespecs. They seem odd to me. Like, won't the breakpoint move at re-set if the variable changes? Also I note that they aren't documented... But your patch is just fixing an error in the existing support, which I think makes it ok to go in. thanks, Tom