Re: [PATCH] Recognize branch instruction on MIPS in gdb.trace/entry-values.exp

[Yao Qi <yao@codesourcery.com>]

"Maciej W. Rozycki" <macro@linux-mips.org> writes:

>  Overall I'd prefer MIPS instructions to be spelled out capitalised in our 
> documentation for consistency with hardware documentation.  This makes 
> them more prominent in text and also avoids confusing them with common 
> words such as in `AND' vs `and'.  The only exception are quoted pieces of 
> assembly code where the language specifies mnemonics as lowercase strings.
>

OK, that is fine to me.

>>  If it is jalrc, set
>> +    # RETURNED_FROM_FOO to insn1, otherwise set RETURNED_FROM_FOO to
>> +    # insn2.
>> +    set call_insn {jalrc|[jb]al[sxr]*[ \t][^\r\n]+\r\n}
>
>  OK, this should work.  I have a minor nit yet: `[sxr]?' will be more 
> accurate than `[sxr]*', you want to see the letter at most once.  The 
> former regexp will likely interpret faster too.

We want to match JALRS, so [sxr]* is needed here.

-- 
Yao (齐尧)