From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH] Recognize branch instruction on MIPS in gdb.trace/entry-values.exp
Date: Mon, 29 Dec 2014 08:15:00 -0000 [thread overview]
Message-ID: <1419840861-10723-1-git-send-email-yao@codesourcery.com> (raw)
The test entry-values.exp doesn't recognize the call instruction "jal"
on MIPS, so this patch sets call_insn "jal" first.
Currently, we assume the next instruction address of call instruction
is the address returned from foo, however it is not correct on MIPS
which has delay slot. We extend variable call_insn to match one
instruction after jal, so that $returned_from_foo is correct on MIPS.
All tests in entry-values.exp are PASS.
gdb/testsuite:
2014-12-29 Yao Qi <yao@codesourcery.com>
* gdb.trace/entry-values.exp: Set call_insn for MIPS target.
---
gdb/testsuite/gdb.trace/entry-values.exp | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/gdb/testsuite/gdb.trace/entry-values.exp b/gdb/testsuite/gdb.trace/entry-values.exp
index 6bb0514..bf395f7 100644
--- a/gdb/testsuite/gdb.trace/entry-values.exp
+++ b/gdb/testsuite/gdb.trace/entry-values.exp
@@ -43,6 +43,16 @@ if { [istarget "arm*-*-*"] || [istarget "aarch64*-*-*"] } {
set call_insn "brasl"
} elseif { [istarget "powerpc*-*-*"] } {
set call_insn "bl"
+} elseif { [istarget "mips*-*-*"] } {
+ # Skip one instruction after jal which is the delay slot.
+ #
+ # jal foo
+ # insn1
+ # insn2
+ #
+ # program goes to insn2 when it returns from foo. We should set
+ # RETURNED_FROM_FOO to insn2.
+ set call_insn "jal\[^\r\n\]+\r\n"
} else {
set call_insn "call"
}
--
1.9.3
next reply other threads:[~2014-12-29 8:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-29 8:15 Yao Qi [this message]
2014-12-29 23:20 ` Maciej W. Rozycki
2014-12-30 12:34 ` Yao Qi
2014-12-30 14:17 ` Maciej W. Rozycki
2015-01-04 8:42 ` Yao Qi
2015-01-07 23:22 ` Maciej W. Rozycki
2015-01-08 1:10 ` Yao Qi
2015-01-08 1:24 ` Maciej W. Rozycki
2015-01-08 3:47 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419840861-10723-1-git-send-email-yao@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox