From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10526 invoked by alias); 8 Jan 2015 01:10:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10504 invoked by uid 89); 8 Jan 2015 01:10:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 08 Jan 2015 01:10:44 +0000 Received: from svr-orw-fem-06.mgc.mentorg.com ([147.34.97.120]) by relay1.mentorg.com with esmtp id 1Y91cW-0003dZ-4T from Yao_Qi@mentor.com ; Wed, 07 Jan 2015 17:10:40 -0800 Received: from GreenOnly (147.34.91.1) by SVR-ORW-FEM-06.mgc.mentorg.com (147.34.97.120) with Microsoft SMTP Server id 14.3.224.2; Wed, 7 Jan 2015 17:10:39 -0800 From: Yao Qi To: "Maciej W. Rozycki" CC: Subject: Re: [PATCH] Recognize branch instruction on MIPS in gdb.trace/entry-values.exp References: <1419840861-10723-1-git-send-email-yao@codesourcery.com> <87zja5uxjk.fsf@codesourcery.com> <87r3vbuecf.fsf@codesourcery.com> Date: Thu, 08 Jan 2015 01:10:00 -0000 In-Reply-To: (Maciej W. Rozycki's message of "Wed, 7 Jan 2015 23:22:22 +0000") Message-ID: <87oaqat6uj.fsf@codesourcery.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00153.txt.bz2 "Maciej W. Rozycki" writes: > Overall I'd prefer MIPS instructions to be spelled out capitalised in ou= r=20 > documentation for consistency with hardware documentation. This makes=20 > them more prominent in text and also avoids confusing them with common=20 > words such as in `AND' vs `and'. The only exception are quoted pieces of= =20 > assembly code where the language specifies mnemonics as lowercase strings. > OK, that is fine to me. >> If it is jalrc, set >> + # RETURNED_FROM_FOO to insn1, otherwise set RETURNED_FROM_FOO to >> + # insn2. >> + set call_insn {jalrc|[jb]al[sxr]*[ \t][^\r\n]+\r\n} > > OK, this should work. I have a minor nit yet: `[sxr]?' will be more=20 > accurate than `[sxr]*', you want to see the letter at most once. The=20 > former regexp will likely interpret faster too. We want to match JALRS, so [sxr]* is needed here. --=20 Yao (=E9=BD=90=E5=B0=A7)